Each and every Key Metrics widget stories also includes all their stories in Visual Regression suite. This is repetitive and unnecessarily increases the VRT running time on CI and bloats the suite. This includes:
Ready
ReadyViewOnly
Loading
ZeroData
GatheringData / DataUnavailable
Error
ErrorMissingCustomDimensions
ErrorCustomDimensionsInsufficientPermissions
ErrorCustomDimensionsGeneric
InsufficientPermissions
The stories for each title should only keep the generic Ready, ReadyViewOnly and any other unique stories for them. ie. AdSenseNotLinked story for TopEarningContentWidget. Besides the unique stories, VRT scenarios should be removed from the generic stories as well. (ie. Ready. ReadyViewOnly).
Instead, the generic VRT scenarios should be added to the actual underlying tile components. ie. MetricTileWrapper, MetricTileText, MetricTileTable, MetricTileNumeric etc.
Specific conditions for a Key Metrics widgets (ie. ErrorMissingCustomDimensions, Error etc) should be verified in component Jest test instead, wherever applicable.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Feature Description
Each and every Key Metrics widget stories also includes all their stories in Visual Regression suite. This is repetitive and unnecessarily increases the VRT running time on CI and bloats the suite. This includes:
The stories for each title should only keep the generic
Ready
,ReadyViewOnly
and any other unique stories for them. ie.AdSenseNotLinked
story forTopEarningContentWidget
. Besides the unique stories, VRT scenarios should be removed from the generic stories as well. (ie.Ready
.ReadyViewOnly
).Instead, the generic VRT scenarios should be added to the actual underlying tile components. ie.
MetricTileWrapper
,MetricTileText
,MetricTileTable
,MetricTileNumeric
etc.Specific conditions for a Key Metrics widgets (ie.
ErrorMissingCustomDimensions
,Error
etc) should be verified in component Jest test instead, wherever applicable.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Test Coverage
QA Brief
Changelog entry