google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 279 forks source link

Do not show hyperlinks on post tiles in Top Earning Pages widget on shared dashboard #8451

Closed kuasha420 closed 2 months ago

kuasha420 commented 3 months ago

Bug Description

As discovered by @wpdarren, currently in the GA4 version of Top Earning Pages widget, the post titles links to analytics report pages on the shared dashboard. This should be replaced with normal text titles as it's done on the Top Earning Contents Key Metrics tile.

Screenshots

image (6)


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

tofumatt commented 3 months ago

IB ✅

aaemnnosttv commented 3 months ago

@tofumatt we have a dedicated component for plain output that we use for Key Metrics https://github.com/google/site-kit-wp/blob/266daf0a43cc6747e2bf9176c44f2ed06a863a74/assets/js/components/KeyMetrics/MetricTileTablePlainText.js#L24

Should we not use a similar approach for these kinds of tables in other widgets?

kuasha420 commented 3 months ago

@aaemnnosttv It makes sense, I can file another issue to introduce the component and refactor this and all our existing widgets to use it.

There's also another point I raised in the Linked PR about the view only footer - if we decide to remove the empty footer on view only dashboard, we should probably do the same in all other widgets as well.

wpdarren commented 3 months ago

QA Update: ✅

Verified:

When signing into the shared dashboard with another user who does not have direct access to the GA4 + AdSense accounts, the Top Earning Pages widget in the Monetization section does have hyperlinks to each page; they are plain text.

image