search

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 278 forks source link

Do not bundle client services that are no longer necessary #8459

Open nfmohit opened 5 months ago

nfmohit commented 5 months ago

Feature Description

We recently removed the legacy Analytics module (UA) from Site Kit as part of the Singular Analytics Module epic. @aaemnnosttv kindly pointed out here that we're still bundling the legacy client services which should no longer be needed.

https://github.com/google/site-kit-wp/blob/06b1aacd9001f22803c8b6eae7a484ca186b41aa/scoper.inc.php#L18

The above, including any other client services that we no longer need should not be bundled.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

mxbclang commented 5 months ago

@nfmohit Can you please add a priority label here? TY!

eugene-manuilov commented 4 days ago

@benbowler, looks like we don't need AnalyticsReporting as well.

benbowler commented 3 days ago

@eugene-manuilov good catch, updated the IB.

aaemnnosttv commented 3 days ago

@benbowler @eugene-manuilov I touched on this in my work on the latest hackathon, and found we can greatly simplify our scoper config with a single Finder instance that automatically sources all non-dev dependencies via Composer. The implementation is quite minimal too, so I'll propose this in a PR since it's basically already done.

Edit: Nevermind, it doesn't make sense to do yet since it would end up prefixing everything from apiclient-services rather than only the parts we use/need. It made sense in my project because I had replaced that library with individual dependencies for only the client libraries we use.

eugene-manuilov commented 3 days ago

Thanks, @benbowler. IB ✔️. I'll adjust the estimate to be 3 instead of 1 to make sure we have enough time for code review and testing.