Error style isn't cleared when submitting changes in settings edit

aaemnnosttv commented 6 months ago

Bug Description

The settings edit interface for a module has additional styling applied when an error is raised in response to saving the settings.

https://github.com/google/site-kit-wp/blob/c04724c4dceae289affe66424690673691f6cb74/assets/js/components/settings/SettingsActiveModule/Footer.js#L106-L110

https://github.com/google/site-kit-wp/blob/c04724c4dceae289affe66424690673691f6cb74/assets/js/components/settings/SettingsActiveModule/index.js#L63-L66

However, this state is never cleared which can leave a lingering error appearance after the error has been addressed or is otherwise no longer relevant.

Steps to reproduce

Set up SK with no additions
Connect GA with an existing property
Edit GA settings and choose to create a new property or datastream and submit
- Note this is technically an error
Follow the prompt to grant additional scope
Back in settings once granted, see the interface shows with the red error border, even after completing the property creation (click edit again)

Screenshots

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The settings error appearance should be removed as soon as the settings submission completes successfully

Implementation Brief

[ ] Update the else block of the handleConfirm to clear the value for errorKey since the submission was successful

Test Coverage

No changes necessary

QA Brief

Follow the "Steps to reproduce".
Ensure "Confirm changes" has been clicked and the settings have saved successfully.
Click edit again, the red border should now be removed.

Changelog entry

Ensure the error style for the Settings edit screen is cleared when settings are saved successfully.

eugene-manuilov commented 6 months ago

IB ✔️

mohitwp commented 1 week ago

QA Update ✅

Tested on dev environment.
Verified that issue is resolved and the red border is removed once the setting is saved, and when the user clicks the edit button again.

https://github.com/user-attachments/assets/d1643059-06dd-482b-a481-a522f17b949e

google / site-kit-wp