search

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.21k stars 278 forks source link

No check for Ads Conversion ID added via GTM #8513

Closed bethanylang closed 1 day ago

bethanylang commented 2 months ago

Feature Description

As reported by @jamesozzie in Ads Module Bug Bash:

image

If following the steps to add Ads Conversion tracking via GTM, it's possible to have both a SK inserted tacking ID and a GTM added tracking tag for a site.

Tested via adding an Ads Conversion Tracking ID manually, on a site that already has the Ads module successfully connected.

If feasible, add a notice within the Ads module, to mention that an existing tag was found - similar to how we do it for GA.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

jimmymadon commented 1 month ago

@jamesozzie (Although the questions below are mainly for @aaemnnosttv )

If feasible, add a notice within the Ads module, to mention that an existing tag was found - similar to how we do it for GA.

As mentioned in this (long) comment, since we moved to GA4, we no longer warn the user when a GTM container contains a "Google Tag (Measurement ID)" that points to the same Web Datastream selected within Google Analytics within the plugin. This functionality was removed from the plugin when we moved from UA to GA4 because:

  1. Having 2 duplicated tags inserted on a site do not duplicate the data / events in GA4.
  2. Fetching the web datastream connected to a Google Tag is not straightforward based on the current Analytics API.

Question 1: Are we sure that having the Ads Conversion ID inserted twice onto the site, via GTM and via Ads does not have any unfortunate side effects?

The only "GTM-GA4" integration we do now is that when GA4 is not connected in the plugin, and if the user connects Tag Manager and selects a GTM container whose current live version has "any valid" Google Tag ID, then we show a message. This message simply encourages the user to set up GA4 within Site Kit.

Screenshot 2024-05-22 at 00 30 30

Question 2: Do we want to encourage the user to "set up Ads" like above if we do find an Ads Conversion ID in the currently selected GTM container?

eclarke1 commented 1 month ago

Does this have to be @aaemnnosttv answering here, or can we loop in @tofumatt or @eugene-manuilov as Squad 1 leads?

jimmymadon commented 1 month ago

Sure - @tofumatt and @eugene-manuilov can guide us here too.

eclarke1 commented 1 month ago

This is the last issue in the Ads Module epic, do we feel this is still needed? If so, can we move it through so we can get the epic closed out please

eugene-manuilov commented 2 weeks ago

Question 1: Are we sure that having the Ads Conversion ID inserted twice onto the site, via GTM and via Ads does not have any unfortunate side effects?

I think the only way to answer this question is to try it and see whether we get duplicate events tracked when we have conversion tracking enabled via GTM and via Ads. @jamesozzie, can you try it using your setup?

Question 2: Do we want to encourage the user to "set up Ads" like above if we do find an Ads Conversion ID in the currently selected GTM container?

@aaemnnosttv, what do you think? I think this question is for you.

jimmymadon commented 1 week ago

Question 2: Do we want to encourage the user to "set up Ads" like above if we do find an Ads Conversion ID in the currently selected GTM container?

On our AC sync yesterday, @aaemnnosttv decided not to at this stage since there is not much value in connecting Ads via just the conversion ID for now.

As for Question 1, @jamesozzie will have a look.

binnieshah commented 4 days ago

@jamesozzie please could you review this?

jamesozzie commented 3 days ago

@jimmymadon @binnieshah Just to confirm I don't see any double tracking applied or issues with double tracking.

In these tests I ensured all users are included in reporting within SK. I didn't in this case check various events. Happy to do so if you let me know of any specific events you'd like me to check @eugene-manuilov

eugene-manuilov commented 1 day ago

Thanks, @jamesozzie. So, looks like here is nothing to do for us. Going to close this ticket.

jamesozzie commented 18 hours ago

Sounds good @eugene-manuilov.

Note that I didn't check any click through from Google Ads directing me to a test website, I don't have Google Ads running for ads sites. Landing on a test website using Site Kit, with a Ads tag placed by both Site Kit and by GTM could potentially result in skewed data, I'm not sure. My tests were basic events, internal and external page clicks. Happy to test further, while I'll also add for discussion in our sync with @aaemnnosttv