Closed zutigrm closed 5 months ago
@zutigrm, in analogy to what we discussed in another ticket, it would be nice to make AC be implementation agnostic. Basically, when we write AC it should always answer the What will we get?
question, whilst IB will answer for the How will we do it?
question.
Debug_Data
class should be updated to include newget_active_conversion_event_provider_fields
method which would retrieve
This ^ tells exactly what we need to do to get the final result, which is more IB-ish information and shouldn't be in the AC section. Much better would be if we write AC that has the following:
* Site Health information displays active conversion event providers and their events that are tracked by Site Kit.
This ^ is the ideal AC for this task and it will be the responsibility of the IB writer to figure out which class to update. In order to help them figure out it, we can add a note in the IB section pointing to the correct section of the design doc, so they can find which class to update and which method name to create.
Could you please adjust your AC? Thanks in advance.
@eugene-manuilov Thanks, that's pretty helpful. Since it is about infrastructure I though I should still include a minimal description. I will follow the What will we get?
as a guideline.
AC updated
Thanks, @zutigrm. AC ✔️
@zutigrm
- It should retrieve event names from active conversion event providers as a mapped array with their names/slugs as keys and event names as values.
How? What do we need to do to get that information?
@eugene-manuilov sorry about that. Expanded on the specifics.
Thanks. IB ✔️
@jimmymadon Just want to confirm currently new added field "Active conversion event providers" also appears when 'conversionInfra:' feature flag is not enabled. No instructions are provided under QAB related to it but just want to reconfirm that changes introuduced under this tickets are not behind feature flag.
As discussed on slack with @jimmymadon . Changes introduced under this PR should be behind feature flag. Moving this back to execution.
conversionInfra
feature flag is disabled then new field is added for "Active conversion event providers" do not appear under site heath.conversionInfra
feature flag is enabled.
Feature Description
Update
Google\Site_Kit\Core\Site_Health\Debug_Data
class to include active conversion event providers and their events that are tracked by Site Kit. See implementation and class design in the design doc.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Google\Site_Kit\Core\Site_Health\Debug_Data
classget_active_conversion_event_provider_fields
methodGoogle\Site_Kit\Core\Conversion_Tracking\Conversion_Tracking::get_active_conversion_event_providers
method, implemented in #8528 to retrieve active coversion event providersget_event_names
method from each individualGoogle\Site_Kit\Core\Conversion_Tracking\Conversion_Events_Provider
.get_fields
methodTest Coverage
tests/phpunit/integration/Core/Site_Health/Debug_DataTest.php
to include new fields in the testsQA Brief
submit_lead_form
.Changelog entry