Closed aaemnnosttv closed 5 months ago
QA Update ✅ Tests included but not limited to:
Nothing to report. LGTM!
Release Testing :heavy_check_mark:
LGTM. :+1:
All looks good to me 👍🏻
I went through our usual QA checks:
Note: I ran some quick UI checks on the application screen for NPT and also ran through some additional testing around 2nd admin users as we've had a few bug tickets recently around 2nd admins.
LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
LGTM 👍
@zutigrm re. your question.
LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
It was decided due to the high profile of the consent mode functionality that we should include it in the entity dashboard too. I am sure Tom can confirm this is the case.
LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
@zutigrm yes, it was defined that way in https://github.com/google/site-kit-wp/issues/8279 👍
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
QA Brief
Changelog entry