google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Release 1.127.0 #8668

Closed aaemnnosttv closed 5 months ago

aaemnnosttv commented 6 months ago

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

QA Brief

Changelog entry

kelvinballoo commented 5 months ago

QA Update ✅ Tests included but not limited to:

Nothing to report. LGTM!

kuasha420 commented 5 months ago

Release Testing :heavy_check_mark:

LGTM. :+1:

tofumatt commented 5 months ago

QA ✅

All looks good to me 👍🏻

wpdarren commented 5 months ago

QA Update: ✅

I went through our usual QA checks:

Note: I ran some quick UI checks on the application screen for NPT and also ran through some additional testing around 2nd admin users as we've had a few bug tickets recently around 2nd admins.

zutigrm commented 5 months ago

QA Verified ✅

LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?

image
nfmohit commented 5 months ago

Release Tested ✅

hussain-t commented 5 months ago

QA Verified :white_check_mark:

LGTM 👍

wpdarren commented 5 months ago

@zutigrm re. your question.

LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?

It was decided due to the high profile of the consent mode functionality that we should include it in the entity dashboard too. I am sure Tom can confirm this is the case.

mohitwp commented 5 months ago

QA Update ✅

jimmymadon commented 5 months ago

QA ✅

aaemnnosttv commented 5 months ago

LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?

@zutigrm yes, it was defined that way in https://github.com/google/site-kit-wp/issues/8279 👍