google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 292 forks source link

Refactor settings Save button loading state #8730

Open jimmymadon opened 6 months ago

jimmymadon commented 6 months ago

Feature Description

As per this internal Slack conversation, the following code snippet can be refactored. The resolution map should be removed from the generic Footer component and each module should implement its own selector to determine which selector should be resolved in order to determine whether it's settings have loaded or not.

https://github.com/google/site-kit-wp/blob/f9a0480c5612f3a6c32e2703a5070792fa7351e9/assets/js/components/settings/SettingsActiveModule/Footer.js#L147-L169


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

tofumatt commented 6 months ago

Works for me 👍🏻

I see there's an IB here already that looks good, so moving this one right to the backlog 😄

IB ✅