Address copy/formatting inconsistencies in "subtle" notifications?

[techanvil]

Feature Description

At present the copy/formatting in the existent "subtle" notifications is a little inconsistent.

SetupSuccessSubtleNotification:

GA4AdSenseLinkedNotification:

AudienceSegmentationSetupSuccessSubtleNotification (PR Storybook instance for pre-merge access):

It's not entirely clear what the outcome here should be as there's a bit of room for interpretation based on the style guide for punctuation (see below).

• We should probably adjust the GA4AdSenseLinkedNotification notification to remove the periods from both sentences, and use the lighter font weight for the second sentence.
• We might also want to remove the period from the second sentence of the AudienceSegmentationSetupSuccessSubtleNotification notification, although this is arguably a "long or complex sentence" and the closing period is pretty well aligned with other sentences of a similar length elsewhere in the plugin,

Style guide:

"Skip periods and unnecessary punctuation

To help readers scan text, avoid using periods and other unnecessary punctuation.

Avoid using periods to end single sentences, particularly in: - Labels - Tooltip text - Bulleted lists - Dialog body text - Hyperlinked text

Use periods on: - Multiple sentences - Long or complex sentences, if it suits the context - Any sentence followed by a link"

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The periods within the GA4AdSenseLinkedNotification notification should be removed from both the sentences, and the lighter font weight should be used for the second sentence.

Implementation Brief

• [x] Remove the periods from both sentences in the GA4AdSenseLinkedNotification notification.
• [ ] Update GA4AdSenseLinkedNotification, adding the class className="googlesitekit-subtle-notification__secondary_description" to the second paragraph in the notification body.

Test Coverage

• Update VRTs to reflect the copy and style changes of the GA4AdSenseLinkedNotification notification.

QA Brief

• Review each of the following subtle notifications in storybook, check the sentences don't end with full stops and the description is light font weight.
  • SetupSuccessSubtleNotification
  • GA4AdSenseLinkedNotification
  • AudienceSegmentationSetupSuccessSubtleNotification

Changelog entry

• Address formatting inconsistencies in subtle notifications by removing periods from GA4AdSenseLinkedNotification and AudienceSegmentationSetupSuccessSubtleNotification.

[jimmymadon]

@techanvil I agree with your suggestions. The period in the lastAudienceSegmentationSetupSuccessSubtleNotification seems to be fine.

[benbowler]

It's worth considering #8725, as this will help introduce consistency is styles across SubtleNotifications (although not the copy).

[nfmohit]

AC ✅

[eugene-manuilov]

IB ✔️

[hussain-t]

Hi @benbowler, the storybook stories links are broken in the QAB. Could you fix them?

[benbowler]

@hussain-t @mohitwp fixed the links.

[mohitwp]

QA Update ✅

• Tested the below storybooks- SetupSuccessSubtleNotification GA4AdSenseLinkedNotification AudienceSegmentationSetupSuccessSubtleNotification

• Verified that the sentences don't end with full stops and the description is light font weight.