google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 287 forks source link

PAX inherits conflicting styles from WP core #8770

Closed aaemnnosttv closed 4 months ago

aaemnnosttv commented 4 months ago

Bug Description

There are a few CSS styles that PAX inherits from WP core which result in a "broken" visual appearance.

Steps to reproduce

  1. Connect Ads via PAX
  2. View Ads widget on dashboard

Screenshots

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Note to the reviewer: Due to the priority of the issue, I already added a PR targeting main, to speed up the inclusion, as it is a very small css change. If IB is ok, it can go straight to the CR

Test Coverage

QA Brief

Changelog entry

eclarke1 commented 4 months ago

This is related to this bug bash item https://app.asana.com/0/1207337163922896/1207344075557379 just FYI

wpdarren commented 4 months ago

QA Update: ✅

Verified:

The PAX dashboard widget has proper styling matching the other widgets. The widget now appears in the entire space of the widget area and looks much more user friendly.

Note: there is a very minor styling issue on smaller viewports and I will create a ticket for this.

image