Open nfmohit opened 4 weeks ago
AC :white_check_mark:
IB :white_check_mark:
As per my conversation with @aaemnnosttv , the generator is part of the same (maintained) client services repo, thus this is what we should use for the generation.
@aaemnnosttv I am assigning this to you for your confirmation. Once you get a chance to look into this, please confirm if we can move this ticket to CR.
Thanks
As discussed on Slack the approach has been confirmed to be correct. I've given the PR another once-over with this in mind, and it's back with @ankitrox with a few more comments.
Thank you @techanvil .
I've made the requested changes. Assigning this to you for re-review.
As per the QAB, there's no need for a QA stage for this. With tests passing it's been CR'd, merged and moved straight to Approval.
Feature Description
The client library for the
subscribewithgoogle
API that is needed by Reader Revenue Manager is not available via the googleapis/google-api-php-client-services package. As a temporary workaround, this client library bindings should be generated and installed for PHP which we can later remove once available in the official client services.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
subscribewithgoogle
v1 API should be generated and added as a new Composer package under/packages/apiclient-services-subscribewithgoogle
.SubscribewithGoogle.php
will be generated which can live in the root.google/apiclient-services-subscribewithgoogle
./third-party/google/
.Implementation Brief
SubscribewithGoogle.php
under the path in the AC and create the necessarycomposer.json
in the same directory. Refer to the generator readme.composer.json
for the plugin to define a newpath
type Composer repository for the new package. This can go next to the currentpackages/apiclient-services-adsenselinks
definition.Note: Refer this PR from "Thank with Google" which has similar implementation.
Test coverage
QA Brief
Changelog entry