google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 279 forks source link

Install the SwG client API library #8783

Open nfmohit opened 4 weeks ago

nfmohit commented 4 weeks ago

Feature Description

The client library for the subscribewithgoogle API that is needed by Reader Revenue Manager is not available via the googleapis/google-api-php-client-services package. As a temporary workaround, this client library bindings should be generated and installed for PHP which we can later remove once available in the official client services.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Note: Refer this PR from "Thank with Google" which has similar implementation.

Test coverage

QA Brief

Changelog entry

kuasha420 commented 2 weeks ago

AC :white_check_mark:

techanvil commented 2 weeks ago

IB :white_check_mark:

ankitrox commented 1 week ago

As per my conversation with @aaemnnosttv , the generator is part of the same (maintained) client services repo, thus this is what we should use for the generation.

@aaemnnosttv I am assigning this to you for your confirmation. Once you get a chance to look into this, please confirm if we can move this ticket to CR.

Thanks

techanvil commented 1 week ago

As discussed on Slack the approach has been confirmed to be correct. I've given the PR another once-over with this in mind, and it's back with @ankitrox with a few more comments.

ankitrox commented 1 week ago

Thank you @techanvil .

I've made the requested changes. Assigning this to you for re-review.

techanvil commented 1 week ago

As per the QAB, there's no need for a QA stage for this. With tests passing it's been CR'd, merged and moved straight to Approval.