google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 278 forks source link

Release automation uses incorrect destination #8790

Closed aaemnnosttv closed 1 month ago

aaemnnosttv commented 3 months ago

Bug Description

The release automation we have in place currently sits within our zips workflow which builds zip files for PRs and the latest builds for our main branches. The zip file is structured the way WP expects: including the plugin's directory, however the release does not account for this so it ends up adding the files in the wrong (nested) destination.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

This will need to be tested by running the release automation task, I don't see another way it can be tested 🤔

Changelog entry

binnieshah commented 2 months ago

@aaemnnosttv could we get an estimate for this one, I am trying to see if we can get this into the next sprint. Thanks

eugene-manuilov commented 1 month ago

IB ✔️

eugene-manuilov commented 1 month ago

Moving to Approval since there is nothing to test.

aaemnnosttv commented 1 month ago

Tested with a dry run here and looks great 🎉