google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.21k stars 278 forks source link

Ensure all version numbers in plugin match each other #8804

Open tofumatt opened 1 month ago

tofumatt commented 1 month ago

Feature Description

Last release I forgot to update the constant value for GOOGLESITEKIT_VERSION, which @aaemnnosttv kindly caught before the release 😅

image

We should set up a PHP unit test that ensures all of these versions values are synced, so when we bump version values they aren't out-of-sync, like they were in a6fe45c8030b97476653f4e3c6360de6684e786a.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Check my draft PR for this ticket #8864

Test Coverage

QA Brief

Changelog entry

benbowler commented 3 weeks ago

As part of experimenting for the IB was able to create draft PR that meets this requirement, also I noticed that the changelog has 1.128.1 but the rest of the app (in develop) is showing 1.128.0.

When reviewing the IB, also review the draft PR.

tofumatt commented 3 weeks ago

@benbowler Yeah, the point release wasn't merged back into main/develop as standard, I think this point release was a bit unorthodox 😅

Good chance to test things out I guess 😆

IB looks good to me. IB ✅