Difference in Font size for Enhance toggle description

[wpdarren]

Bug Description

As reported by @kelvinballoo on the Asana bug bash board

The font size for the Enhance Toggle description is 12px, it should be 14px, similar to all the other text in that expanded module.

Figma says it's 14px anyway:

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The font-size for .googlesitekit-settings-module__fields-group-helper-text should be 14px, not 12px.

Implementation Brief

• [ ] Add font-size: 14px to https://github.com/google/site-kit-wp/blob/4245339ddc727f006e6b33deb7c1a5f2ccae2f09/assets/sass/components/ads/_googlesitekit-ads-settings.scss#L27

Test Coverage

• No new tests are needed.

QA Brief

• Setup Site Kit and connect Ads and Analytics modules
• Confirm the font size and color for the Enhanced conversion tracking Toggle description (in Analytics and Ads module settings edit view) match the Figma designs.

Changelog entry

• N/A

[eugene-manuilov]

IB ✔️

[mohitwp]

QA Update ⚠️

@benbowler As per QAB `font size and font color for the Enhanced conversion tracking Toggle description should match the figma design . But, In the Analytics edit settings view, the 'Enable Enhanced Conversion Tracking' toggle description has a font size of 14px, which matches the Figma design. However, the font color differs from the Figma file, where the color is #6C726E. I believe the current implementation aligns with the existing styling. Can you please confirm if the font color should also be changed to #6C726E?

Figma Analytics-  Analytics module - 

Pass cases

Ads module-  Analytics module - 

[benbowler]

Hey @mohitwp, good point, this ticket was originally about the font size. I suggest with create a follow up ticket, something like "Unify settings helper text color", were we address this for all settings screens, otherwise we could get into a situation where there are differences between different toggles/different settings screens, what do you think?

[mohitwp]

QA Update ✅

Thanks @benbowler for the confirmation ! Yes, I have same thought that for consistency current implementation is correct. I will create separate ticket to implement consistency under settings page.

• Tested on dev environment.
• Verified the font size and for the Enhanced conversion tracking Toggle description (in Analytics and Ads module settings edit view) match the Figma designs which is 14px.

Ads module-  Analytics module -