google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.21k stars 278 forks source link

Implement `<PublicationOnboardingStateNotice>` component #8838

Open nfmohit opened 3 weeks ago

nfmohit commented 3 weeks ago

Feature Description

A <PublicationOnboardingStateNotice> component should be implemented for the Reader Revenue Manager module that renders a notice based on the onboarding state of the current publication.

Screenshot for reference ![image](https://github.com/google/site-kit-wp/assets/20284937/9bcf7fc9-f5b3-4ee7-b9e4-5d1b3a1c2329)

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Note: PropertySelect component in #8837 will be responsinble for setting the onboarding state in the settings using the setPublicationOnboardingState action. This has already described in IB for #8837.

Test Coverage

Add tests for component with different onboarding states.

QA Brief

Changelog entry

nfmohit commented 6 days ago

Thank you for the excellent IB here, @ankitrox !

One small point about the CTA link. We should use the getServiceURL selector with the current publication ID passed to get the URL for the CTA. Could you please update it?

Thanks!

ankitrox commented 5 days ago

@nfmohit Thank you for reviewing the IB.

I've amended the suggested point. Assigning back to you.

nfmohit commented 2 days ago

Thanks @ankitrox ! IB LGTM 👍 ✅