Open kelvinballoo opened 2 weeks ago
Initially I looked into a more general solution, the reason this is happening is that we have this block in CSS where if multiple mdc-layout-grid
divs are next to each other, the following elements have 0 top padding. We don't want to remove this though as this helps group other grid elements together across the plugin.
Instead I specifically apply padding for this widget area only.
Thanks @benbowler. This seems fine for now, we can revisit it more generally if/when we need it in future.
IB :white_check_mark:
Bug Description
Margin on top of text of the Change groups CTA should be 32px and not 24px.
Steps to reproduce
Screenshots
Details Implementation : 24px
Figma: 32px
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/components/analytics-4/audience-segmentation/_googlesitekit-audience-widget-area.scss
, adding the following styles:.googlesitekit-widget-area--mainDashboardTrafficAudienceSegmentation
,padding-top: 3px
on the mobile breakpoints..googlesitekit-widget-area--mainDashboardTrafficAudienceSegmentation
,padding-top: 8px
on the desktop breakpoints.Test Coverage
QA Brief
Changelog entry