google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 286 forks source link

Only render the Audience Segmentation Setup CTA when Analytics is connected #8876

Open techanvil opened 3 months ago

techanvil commented 3 months ago

Feature Description

This is a small cleanup, as at present the Setup CTA won't actually be displayed when Analytics isn't connected due to its internal check for Analytics data availability on load. However it would be preferable to entirely avoid rendering the component when Analytics is not connected, thus avoiding redundant Analytics store lookups and so forth.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

https://github.com/google/site-kit-wp/blob/774ea23c2471170c96898f11c1909dedf6bc5db3/assets/js/components/DashboardMainApp.js#L262-L264

Test Coverage

QA Brief

Changelog entry

nfmohit commented 3 months ago

IB ✅

techanvil commented 3 months ago

Moved to Backlog until we get all the P1 issues done and/or the initial release out.