Closed kelvinballoo closed 2 weeks ago
Note: I tested this out, with intermittent results. In my initial testing the bug only occurred when the first tile was in the zero data state. However, I tried it again while reviewing Question 3 in this comment, and found the bug occurred while the first tile did have data.
Hi @kelvinballoo ,
Thank you for reporting this issue.
New Visitors
and Returning Visitors
audiences are created only on 20th June, 2024.New Visitors
and Returning Visitors
, this issue will get addressed in #8144 for which we already have the ticket.@techanvil Please let me know if we should handle this edge case for user created audiences. I think this should get addressed because user created audience can be created at later point and may get added in audience tile, so instead of showing the zero data in rows, we can display the current metrics value and partial data badge (which is already there).
@kelvinballoo Please look at this screencast which shows the above mentioned scenario in SK dashboard.
Hi @ankitrox, as you've pointed out this issue can also occur with user-created audiences that we don't have the special-case handling for. So we do need a general fix for this issue.
IB :white_check_mark:
Bug Description
While testing the audience segmentation epic, I noticed that the 2nd tile doesn't come with value at all. It is always 0, even if it actually should have data. Refer to the screenshots further down where I swapped the positions of an audience where there was a tile with numbers.
Steps to reproduce
Screenshots
When 'All Visitors' is in position 1, there is data for the first 4 lines with 5.9K visitors, etc... :
When the same tile is swapped in position 2, there is no data. It's worth noting that the analytics figures at the bottom are showing accordingly.
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget.js
currentMetricValues
andpreviousMetricValues
respectively by looking up the rows by theiraudienceResourceName
anddateRange
dimensions.currentMetricValues
andpreviousMetricValues
with their corresponding indexes.Note: We can use https://github.com/google/site-kit-wp/pull/8997 as a starting point which covers the proposed fix.
Test Coverage
QA Brief
Steps to reproduce
Changelog entry