Closed techanvil closed 4 weeks ago
IB :white_check_mark:
There were some figma discrepancies found but these can be ignored for now since they are minor. The only thing I want to flag is that we need to remove the period from the copy: 'Create groups suggested by Site Kit'
Hi @kelvinballoo, I can remove the period as part of 8164 which I just move to CR.
Reviewed the text and the period has been removed now.
This is ready to go. Moving ticket to approval
Other items reviewed as part of this ticket are:
Feature Description
Create the Audience Creation Notice, as a presentational component (i.e. implement the visual design but not the business logic), and add it to Storybook.
See audience creation in the design doc.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
In
assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/constants.js
:AUDIENCE_CREATION_NOTICE_SLUG
with the valueaudience-segmentation-creation-notice
(or an appropriate key value).AudienceCreationNotice
componentIn
assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel
directory, create a new fileAudienceCreationNotice.js
:AudienceCreationNotice
, that will be used to render the Audience Creation Notice.getConfigurableAudiences
selector. For example, see how this is being filteredAudienceItems
component: https://github.com/google/site-kit-wp/blob/8240ccf423e84ab53dc7fcea36833feae1736235/assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/AudienceItems.js#L60-L70SITE_KIT_AUDIENCE_DEFINITIONS
.AddGroupNotice
component.SelectionPanel
component.SelectionPanelHeader
component: https://github.com/google/site-kit-wp/blob/7ea3bb35dd70112f679f6336b6d0f5d0b327aa3e/assets/js/components/SelectionPanel/SelectionPanelHeader.js#L39-L45dismissItem
action with theAUDIENCE_CREATION_NOTICE_SLUG
constant to theonClick
event of the close button.SpinnerButton
component with the following props:children
:Create
spinnerPosition
:SPINNER_POSITION.BEFORE
(before
).onClick
handler will be implemented in #8164.assets/sass/components/analytics-4/audience-segmentation/_googlesitekit-audience-selection-panel.scss
.Test Coverage
assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/AudienceCreationNotice.stories.js
.AudienceCreationNotice
component inassets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/AudienceCreationNotice.test.js
.QA Brief
Changelog entry