google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 278 forks source link

Implement the Audience Creation Notice as a presentational component (Storybook) #8986

Closed techanvil closed 4 weeks ago

techanvil commented 1 month ago

Feature Description

Create the Audience Creation Notice, as a presentational component (i.e. implement the visual design but not the business logic), and add it to Storybook.

See audience creation in the design doc.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

In assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/constants.js:

AudienceCreationNotice component

In assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel directory, create a new file AudienceCreationNotice.js:

Test Coverage

QA Brief

Changelog entry

techanvil commented 1 month ago

IB :white_check_mark:

kelvinballoo commented 1 month ago

QA update ⚠️

There were some figma discrepancies found but these can be ignored for now since they are minor. The only thing I want to flag is that we need to remove the period from the copy: 'Create groups suggested by Site Kit'

Figma copy without period: Screenshot 2024-07-26 at 11 57 14 Implemented copy with period: Screenshot 2024-07-26 at 11 58 40
hussain-t commented 1 month ago

Hi @kelvinballoo, I can remove the period as part of 8164 which I just move to CR.

kelvinballoo commented 1 month ago

QA Update ✅

Reviewed the text and the period has been removed now.

Screenshot 2024-07-31 at 19 24 18

This is ready to go. Moving ticket to approval

Other items reviewed as part of this ticket are: