google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 289 forks source link

Update the "insufficient permissions" modals to display the second sentence on a separate line. #9004

Open techanvil opened 3 months ago

techanvil commented 3 months ago

Feature Description

As discussed on Figma, we should update the main "Additional Permissions Required" and the Audience Segmentation "Insufficient permissions" error modal so the text "Trouble getting access?" starts on a new line.

Here's how the "Additional Permissions Required" modal currently looks: image

And here's the Audience Segmentation "Insufficient permissions" error modal: image

The Audience Segmentation modal should be updated with the text on a new line as seen in Figma.: image

The "Additional Permissions Required" modal doesn't have a Figma design to refer to but should be updated along the same lines.

Please note that when updating the Audience Segmentation modal it's not expected for the modal to precisely match Figma, as discussed on this Figma thread. This issue should only be scoped to the line break aspect.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

techanvil commented 1 week ago

Update: This may no longer be required, as the Figma designs have been updated. To be reviewed when revisiting this issue.