Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
The SetupUsingProxyWithSignIn stories should be updated as follows
The "User Input" stories should be removed
The "Start" story should be representative of the default case (the "Analytics inactive" case can be removed as this is also the default)
The "Reset Site Kit" link should only appear in a new "Connected" variant (most stories should be showing the pre-connected state, except for those that require/imply connection like Dashboard Sharing)
Currently it is not showing the variation with "Connect analytics" as part of the setup. Include provideModules with Analytics module being inactive and not connected
Rename it to the Default
[ ] Update Disconnected - URL Mismatch story
Include some URL as the connectedProxyURL property in provideUserAuthentication. Currently it shows undefined for old url, new url is http://example.com, so use something different, so it doesn't show undefined
[ ] Add Revoked access story variation
To show this variation, include url query argument: googlesitekit_context with value of revoked
To achieve this, use withQuery function, and pass the query to the arguments. You can see example usage in assets/js/components/notifications/SetupSuccessBannerNotification.stories.js
[ ] Add Reset Success story, to show the the banner
Include query argument notification with value of reset_success
[ ] Add Skip sign-in story
Add provideSiteConnection with properties: hasMultipleAdmins: true , hasConnectedAdmins: true , and resettable: true - to also show the reset link
Add viewable module, you can use search-console and assign PERMISSION_READ_SHARED_MODULE_DATA capability to the user for it. You can see an example in assets/js/components/ViewOnlyMenu/index.stories.js
Several urls should be mocked as well, to mimic the complete status of compatibility checks, you can transfer the data mock with mocked fetch calls from assets/js/components/setup/CompatibilityChecks/index.test.js, test case should not contain incomplete or error messages if checks are successful
We have used fetch mock in stories in the past, like in the stories/tour-tooltips.stories.js
Feature Description
Our stories for "Using Proxy with Sign-in" aren't showing properly and need updating.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
SetupUsingProxyWithSignIn
stories should be updated as followsImplementation Brief
assets/js/components/setup/SetupUsingProxyWithSignIn.stories.js
[User Input]
story variationsStart - with Analytics Inactive
storyStart
story:provideModules
with Analytics module being inactive and not connectedDefault
Disconnected - URL Mismatch
storyconnectedProxyURL
property inprovideUserAuthentication
. Currently it showsundefined
for old url, new url ishttp://example.com
, so use something different, so it doesn't showundefined
Revoked access
story variationgooglesitekit_context
with value ofrevoked
withQuery
function, and pass thequery
to the arguments. You can see example usage inassets/js/components/notifications/SetupSuccessBannerNotification.stories.js
Reset Success
story, to show the the bannernotification
with value ofreset_success
Skip sign-in
storyprovideSiteConnection
with properties:hasMultipleAdmins: true
,hasConnectedAdmins: true
, andresettable: true
- to also show the reset linksearch-console
and assignPERMISSION_READ_SHARED_MODULE_DATA
capability to the user for it. You can see an example inassets/js/components/ViewOnlyMenu/index.stories.js
complete
status of compatibility checks, you can transfer the data mock with mocked fetch calls fromassets/js/components/setup/CompatibilityChecks/index.test.js
, test caseshould not contain incomplete or error messages if checks are successful
stories/tour-tooltips.stories.js
Test Coverage
QA Brief
Changelog entry