Open techanvil opened 1 month ago
@techanvil Thanks for creating this issue. I reviewed this initially and then discussed it on our AC sync today.
"We will not check if the Google Tag points to an actual GA4 web data stream until perhaps direct API support is available to find these details from a Google Tag ID"
The above is pretty much the only thing we can do now, i.e. when Analytics is not already connected, we can tell the user for sure now that their Google Tag Manager container contains a tag that points to a Analytics 4 Measurement ID. We agreed that this isn't something that is worth our time and effort as this information doesn't change anything for our users. We already "assume" this to be the case and suggest the user connect Analytics when we implemented issue #7990.
So I think we can close this issue. This is good documentation that we have reviewed #7989/#7990 after the Google Tag API development.
c.c. @aaemnnosttv
Thanks @jimmymadon – it sounds like there isn't much benefit to implementing this as defined as you noted but I'd like to get @techanvil 's perspective in case we've missed anything in our review.
Feature Description
Now that we have the ability to lookup a Tag Manager container by tag ID, we should implement the more specific messaging for the GTM and GA integration screens that was originally specced for https://github.com/google/site-kit-wp/issues/7990 (see https://github.com/google/site-kit-wp/issues/7989#issuecomment-1915654586).
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
googtag
) which has the measurement ID as a destination, then display the following screen (which was originally shown when UA was setup and a property ID matched).googtag
) which has a measurement ID as a destination, then display the following screen:/wp-admin/admin.php?page=googlesitekit-dashboard&slug=analytics&reAuth=true
). The text which should be added just below the heading and above the "Please select the account information below." line is as follows:Implementation Brief
Test Coverage
QA Brief
Changelog entry