Closed 10upsimon closed 1 month ago
AC ✔️
IB ✔️
Hey @10upsimon, it looks like the VRT tests for the KeyMetrics/TopCitiesDrivingAddToCartWidget/Ready
were failing when they were added - here's the VRT test run from the Checks tab for the PR: https://github.com/google/site-kit-wp/actions/runs/11047842007/job/30689883579?pr=9409
Please could you raise a followup PR to fix these?
@mohitwp I've moved this back to execution with Simon for the fix.
Cc @zutigrm @eugene-manuilov
@10upsimon Is this ticket ready for CR ?
@mohitwp this should be good to go straight into QA as it was merged prior to the failing tests. I have opened a new PR against develop that show the VRTs now pass against the current develop branch (see https://github.com/google/site-kit-wp/actions/runs/11146601551/job/30978940714?pr=9452)
This is good to be QA'd no and I've assigned to you.
cc @techanvil @zutigrm @tofumatt @aaemnnosttv
Top cities driving add to cart
widget available under KMW panel when conversionReporting
feature flag is not enabled.Top cities driving add to cart
widget is not available under KMW panel if conversionReporting
feature flag is not enabled.Top cities driving add to cart
is showing zero data if data is not available for selected property or selected date range."Cities where visitors most frequently add products to their carts"
used for description and the tooltip.
Feature Description
One of the identified metric tiles for the ACR epic is
Top cities driving add to cart
. Details of this metric tile are as follows:add_to_cart
addToCarts
city
Figma design: TBA
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Top cities driving add to cart
ACR widget is introduced to the existing list of widgets available within KMWaddToCarts
metric based oncity
dimension (returning top 3 results)Cities where visitors most frequently add products to their carts
should be used for description and the tooltipadd_to_cart
event is not present, orconversionReporting
feature flag is not enabledImplementation Brief
assets/js/googlesitekit/datastore/user/constants.js
KM_ANALYTICS_TOP_CITIES_DRIVING_ADD_TO_CART
, holding a stringkmAnalyticsTopCitiesDrivingAddToCart
assets/js/components/KeyMetrics/key-metrics-widgets.js
KM_ANALYTICS_TOP_CITIES_DRIVING_ADD_TO_CART
title
description
andtooltip
requiredConversionEventName
, and assign it an array value containingadd_to_cart
event namedisplayInList
pass the helper functionshouldDisplayWidgetWithConversionEvent
assets/js/modules/analytics-4/components/widgets/TopCitiesDrivingAddToCartWidget.js
assets/js/modules/analytics-4/components/widgets/TopCitiesWidget.js
for example, as a starting pointreportOptions
:city
for dimensionsaddToCarts
metricnot set
dimension value for the city. You can see an example inTopCitiesDrivingLeadsWidget
assets/js/modules/analytics-4/index.js
to include new widget registrationTest Coverage
QA Brief
Top cities driving add to cart
widget is not availableconversionReporting
feature flagTop cities driving add to cart
tileTop cities driving add to cart
widget is showing zero data (since the widget will only be having data on properties that have required ACR events and data associated with them)Changelog entry
Top cities driving add to cart
widget.