google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Creation of `Top cities driving add to cart` ACR KMW #9156

Closed 10upsimon closed 1 month ago

10upsimon commented 3 months ago

Feature Description

One of the identified metric tiles for the ACR epic is Top cities driving add to cart. Details of this metric tile are as follows:

Figma design: TBA


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

eugene-manuilov commented 2 months ago

AC ✔️

eugene-manuilov commented 2 months ago

IB ✔️

techanvil commented 1 month ago

Hey @10upsimon, it looks like the VRT tests for the KeyMetrics/TopCitiesDrivingAddToCartWidget/Ready were failing when they were added - here's the VRT test run from the Checks tab for the PR: https://github.com/google/site-kit-wp/actions/runs/11047842007/job/30689883579?pr=9409

Please could you raise a followup PR to fix these?

@mohitwp I've moved this back to execution with Simon for the fix.

Cc @zutigrm @eugene-manuilov

mohitwp commented 1 month ago

@10upsimon Is this ticket ready for CR ?

10upsimon commented 1 month ago

@mohitwp this should be good to go straight into QA as it was merged prior to the failing tests. I have opened a new PR against develop that show the VRTs now pass against the current develop branch (see https://github.com/google/site-kit-wp/actions/runs/11146601551/job/30978940714?pr=9452)

This is good to be QA'd no and I've assigned to you.

cc @techanvil @zutigrm @tofumatt @aaemnnosttv

mohitwp commented 1 month ago

QA Update ❌

https://github.com/user-attachments/assets/fd3d4d07-cda4-434b-816d-6b9755047ead
mohitwp commented 1 month ago

QA Update ✅

_When conversionReporting feature flag not enabled._ https://github.com/user-attachments/assets/e65e5211-23bc-4641-88c8-ec05b227ecf4 _When conversionReporting feature flag is enabled._ https://github.com/user-attachments/assets/1ee1c40d-1ecc-43fd-a475-da8194effe31 ![image](https://github.com/user-attachments/assets/7fe0a8f1-8809-469f-b6a8-084ca05b1553) ![image](https://github.com/user-attachments/assets/36cdab74-70a5-42b8-86af-3dc8e0e752c4) ![image](https://github.com/user-attachments/assets/c4bf1872-ae91-4f58-a3ef-9ab02f4ff31f) ![image](https://github.com/user-attachments/assets/a8374f2f-64ae-4ae0-9bf7-c53b8fa88b85)