Add async attribute to RRM web tag - Githubissues

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

https://sitekit.withgoogle.com

Apache License 2.0

1.25k stars 291 forks source link

Add async attribute to RRM web tag #9187

Closed nfmohit closed 2 months ago

nfmohit commented 2 months ago

Summary

Addresses issue:

9055

Relevant technical choices

This PR adds the async attribute to the RRM web tag.

PR Author Checklist

[ ] My code is tested and passes existing unit tests.
[ ] My code has an appropriate set of unit tests which all pass.
[ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[ ] My code follows the WordPress coding standards.
[ ] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[x] Run the code.
[x] Ensure the acceptance criteria are satisfied.
[x] Reassess the implementation with the IB.
[x] Ensure no unrelated changes are included.
[x] Ensure CI checks pass.
[ ] Check Storybook where applicable.
[x] Ensure there is a QA Brief.

Merge Reviewer Checklist

[x] Ensure the PR has the correct target branch.
[x] Double-check that the PR is okay to be merged.
[x] Ensure the corresponding issue has a ZenHub release assigned.
[x] Add a changelog message to the issue.

github-actions[bot] commented 2 months ago

Build files for 89bc9de36c8b6e2df754dc70e66175b939ac7ecd have been deleted.