google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Update RRM settings screens to handle edge case scenarios #9201

Closed nfmohit closed 2 months ago

nfmohit commented 2 months ago

Summary

Addresses issue:

Relevant technical choices

This PR updates the RRM settings edit screen to handle scenarios such as publication not available and no module access.

Unrelated changes

PR Author Checklist


Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Merge Reviewer Checklist

github-actions[bot] commented 2 months ago

Build files for 05cbd7f55e30ceb998dcd69a30f9fe140b984359 have been deleted.

github-actions[bot] commented 2 months ago

Size Change: +497 B (+0.03%)

Total Size: 1.78 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.7 kB +32 B (+0.05%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB +1 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.95 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.97 kB +1 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.94 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.3 kB -3 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.88 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.1 kB -3 B (-0.01%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83 kB +72 B (+0.09%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 152 kB -2 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -1 B (0%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB +5 B (+0.02%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB -125 B (-0.1%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 20.8 kB +370 B (+1.81%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.6 kB +133 B (+0.23%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB +11 B (+0.03%)
./dist/assets/js/googlesitekit-settings-********************.js 82.6 kB -9 B (-0.01%)
./dist/assets/js/googlesitekit-splash-********************.js 88.7 kB +3 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 62.5 kB +1 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB +1 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 81.7 kB +2 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB +9 B (+0.01%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `./dist/assets/css/googlesitekit-admin-css-********************.min.css` | 57 kB | | `./dist/assets/css/googlesitekit-adminbar-css-********************.min.css` | 11.8 kB | | `./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css` | 846 B | | `./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css` | 8.2 kB | | `./dist/assets/js/31-********************.js` | 2.76 kB | | `./dist/assets/js/32-********************.js` | 2.25 kB | | `./dist/assets/js/33-********************.js` | 3.64 kB | | `./dist/assets/js/34-********************.js` | 935 B | | `./dist/assets/js/35-********************.js` | 892 B | | `./dist/assets/js/36-********************.js` | 3.12 kB | | `./dist/assets/js/analytics-advanced-tracking-********************.js` | 901 B | | `./dist/assets/js/googlesitekit-components-gm3-********************.js` | 10.1 kB | | `./dist/assets/js/googlesitekit-consent-mode-********************.js` | 25.6 kB | | `./dist/assets/js/googlesitekit-data-********************.js` | 2.35 kB | | `./dist/assets/js/googlesitekit-datastore-location-********************.js` | 2.08 kB | | `./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js` | 646 B | | `./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js` | 624 B | | `./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js` | 630 B | | `./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js` | 712 B | | `./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js` | 675 B | | `./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js` | 634 B | | `./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js` | 657 B | | `./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js` | 633 B | | `./dist/assets/js/googlesitekit-i18n-********************.js` | 3.93 kB | | `./dist/assets/js/googlesitekit-modules-analytics-4-********************.js` | 165 kB | | `./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js` | 22.4 kB | | `./dist/assets/js/googlesitekit-notifications-********************.js` | 21.6 kB | | `./dist/assets/js/googlesitekit-polyfills-********************.js` | 377 B | | `./dist/assets/js/runtime-********************.js` | 1.3 kB |

compressed-size-action

nfmohit commented 2 months ago

Note: The failing VRT scenario does not appear to be related to the changes here. I've re-run it again.

image