Enhancement/#8144 - Handle “new visitors” and “returning visitors” to avoid the “partial data” state

hussain-t commented 3 weeks ago

Summary

Addresses issue:

8144

Relevant technical choices

This PR addresses the error states for the "new" and "returning" visitors reports for displaying the full-width error widget.

PR Author Checklist

[x] My code is tested and passes existing unit tests.
[ ] My code has an appropriate set of unit tests which all pass.
[ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[ ] My code follows the WordPress coding standards.
[ ] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[x] Run the code.
[x] Ensure the acceptance criteria are satisfied.
[x] Reassess the implementation with the IB.
[x] Ensure no unrelated changes are included.
[x] Ensure CI checks pass.
[x] Check Storybook where applicable.
[x] Ensure there is a QA Brief.

Merge Reviewer Checklist

[x] Ensure the PR has the correct target branch.
[x] Double-check that the PR is okay to be merged.
[x] Ensure the corresponding issue has a ZenHub release assigned.
[x] Add a changelog message to the issue.

github-actions[bot] commented 3 weeks ago

Build files for 357eea28837e2dcc69213c60bb4171f748129bde have been deleted.

github-actions[bot] commented 3 weeks ago

Size Change: +8.4 kB (+0.47%)

Total Size: 1.81 MB

Filename	Size	Change
`./dist/assets/js/googlesitekit-activation-********************.js`	23.8 kB	+15 B (+0.06%)
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	73.1 kB	+1.72 kB (+2.42%)
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.5 kB	+50 B (+0.15%)
`./dist/assets/js/googlesitekit-api-********************.js`	9.97 kB	-3 B (-0.03%)
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	5.97 kB	+1 B (+0.02%)
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10.1 kB	-6 B (-0.06%)
`./dist/assets/js/googlesitekit-datastore-forms-********************.js`	8.95 kB	+1 B (+0.01%)
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.08 kB	-1 B (-0.05%)
`./dist/assets/js/googlesitekit-datastore-site-********************.js`	20.3 kB	-18 B (-0.09%)
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	26.1 kB	-16 B (-0.06%)
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	83.3 kB	+284 B (+0.34%)
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	156 kB	+1.01 kB (+0.65%)
`./dist/assets/js/googlesitekit-modules-********************.js`	22.1 kB	+1 B (0%)
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	32.8 kB	+2 B (+0.01%)
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	125 kB	+249 B (+0.2%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	169 kB	+701 B (+0.42%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.5 kB	+24 B (+0.11%)
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	21.7 kB	+10 B (+0.05%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	58.6 kB	+37 B (+0.06%)
`./dist/assets/js/googlesitekit-modules-tagmanager-********************.js`	32 kB	+10 B (+0.03%)
`./dist/assets/js/googlesitekit-notifications-********************.js`	18.5 kB	-5 B (-0.03%)
`./dist/assets/js/googlesitekit-polyfills-********************.js`	378 B	+1 B (+0.27%)
`./dist/assets/js/googlesitekit-settings-********************.js`	83.3 kB	+341 B (+0.41%)
`./dist/assets/js/googlesitekit-splash-********************.js`	91 kB	+1.61 kB (+1.8%)
`./dist/assets/js/googlesitekit-user-input-********************.js`	64.7 kB	+1.69 kB (+2.68%)
`./dist/assets/js/googlesitekit-vendor-********************.js`	321 kB	+12 B (0%)
`./dist/assets/js/googlesitekit-widgets-********************.js`	86.2 kB	+590 B (+0.69%)
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	61.8 kB	+92 B (+0.15%)
`./dist/assets/js/runtime-********************.js`	1.3 kB	+2 B (+0.15%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./dist/assets/css/googlesitekit-admin-css-********************.min.css` | 57.5 kB | | `./dist/assets/css/googlesitekit-adminbar-css-********************.min.css` | 11.8 kB | | `./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css` | 846 B | | `./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css` | 8.2 kB | | `./dist/assets/js/31-********************.js` | 2.76 kB | | `./dist/assets/js/32-********************.js` | 2.25 kB | | `./dist/assets/js/33-********************.js` | 3.64 kB | | `./dist/assets/js/34-********************.js` | 935 B | | `./dist/assets/js/35-********************.js` | 892 B | | `./dist/assets/js/36-********************.js` | 3.12 kB | | `./dist/assets/js/analytics-advanced-tracking-********************.js` | 901 B | | `./dist/assets/js/googlesitekit-consent-mode-********************.js` | 25.6 kB | | `./dist/assets/js/googlesitekit-data-********************.js` | 2.37 kB | | `./dist/assets/js/googlesitekit-datastore-ui-********************.js` | 9.91 kB | | `./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js` | 646 B | | `./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js` | 624 B | | `./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js` | 630 B | | `./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js` | 712 B | | `./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js` | 675 B | | `./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js` | 634 B | | `./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js` | 657 B | | `./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js` | 633 B | | `./dist/assets/js/googlesitekit-i18n-********************.js` | 3.93 kB |

_{compressed-size-action}

benbowler commented 2 weeks ago

Thanks @hussain-t, I resolved the conflicts with the useInViewSelect work as I was working on that ticket and moving to MR once the checks pass.

hussain-t commented 5 days ago

Thanks for the valuable feedback, @techanvil. I've addressed them.

hussain-t commented 3 days ago

Thanks so much for the fixes, @techanvil. I have made a couple of minor fixes and fixed the failing tests. Please note that VRT keeps failing randomly upon several attempts.

techanvil commented 3 days ago

Thanks so much for the fixes, @techanvil. I have made a couple of minor fixes and fixed the failing tests. Please note that VRT keeps failing randomly upon several attempts.

No problem @hussain-t. I've also taken a look at the VRT and realised it needed an update so I've pushed that as well to move this along. I also updated a JS test which was sometimes failing for me locally.

google / site-kit-wp