google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 279 forks source link

Convert WP Data registry actions to `yield controls`. #9234

Closed tofumatt closed 2 weeks ago

tofumatt commented 3 weeks ago

Summary

Addresses issue:

Relevant technical choices

It wasn't too much more work to convert all files, so did this all at once to allow us to immediately remove/deprecate unused/old functions.

PR Author Checklist


Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

Merge Reviewer Checklist

github-actions[bot] commented 3 weeks ago

Build files for 413dc031f9b1d33036ea7c08ab12e640e5d5014f have been deleted.

github-actions[bot] commented 3 weeks ago

Size Change: +171 B (+0.01%)

Total Size: 1.79 MB

Filename Size Change
./dist/assets/js/36-********************.js 3.12 kB -1 B (-0.03%)
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 72.5 kB -1 B (0%)
./dist/assets/js/googlesitekit-api-********************.js 9.99 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.97 kB -1 B (-0.02%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-data-********************.js 2.38 kB +26 B (+1.11%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB +1 B (+0.05%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.3 kB -74 B (-0.36%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.89 kB -28 B (-0.28%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.9 kB -174 B (-0.67%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83.9 kB -4 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB +17 B (+0.08%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB +4 B (+0.01%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB -47 B (-0.04%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 168 kB +405 B (+0.24%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB +8 B (+0.04%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 21.4 kB -19 B (-0.09%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.6 kB -15 B (-0.03%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB +130 B (+0.41%)
./dist/assets/js/googlesitekit-notifications-********************.js 16.3 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B -1 B (-0.26%)
./dist/assets/js/googlesitekit-settings-********************.js 82.7 kB -5 B (-0.01%)
./dist/assets/js/googlesitekit-splash-********************.js 88.9 kB -2 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 62.7 kB -2 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB -4 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 85.2 kB -48 B (-0.06%)
./dist/assets/js/runtime-********************.js 1.3 kB +2 B (+0.15%)
ℹ️ View Unchanged | Filename | Size | | :--- | :---: | | `./dist/assets/css/googlesitekit-admin-css-********************.min.css` | 57.5 kB | | `./dist/assets/css/googlesitekit-adminbar-css-********************.min.css` | 11.8 kB | | `./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css` | 846 B | | `./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css` | 8.2 kB | | `./dist/assets/js/31-********************.js` | 2.76 kB | | `./dist/assets/js/32-********************.js` | 2.25 kB | | `./dist/assets/js/33-********************.js` | 3.64 kB | | `./dist/assets/js/34-********************.js` | 935 B | | `./dist/assets/js/35-********************.js` | 892 B | | `./dist/assets/js/analytics-advanced-tracking-********************.js` | 901 B | | `./dist/assets/js/googlesitekit-adminbar-********************.js` | 34.5 kB | | `./dist/assets/js/googlesitekit-consent-mode-********************.js` | 25.6 kB | | `./dist/assets/js/googlesitekit-datastore-forms-********************.js` | 8.96 kB | | `./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js` | 646 B | | `./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js` | 624 B | | `./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js` | 630 B | | `./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js` | 712 B | | `./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js` | 675 B | | `./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js` | 634 B | | `./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js` | 657 B | | `./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js` | 633 B | | `./dist/assets/js/googlesitekit-i18n-********************.js` | 3.93 kB | | `./dist/assets/js/googlesitekit-main-dashboard-********************.js` | 155 kB | | `./dist/assets/js/googlesitekit-wp-dashboard-********************.js` | 61.6 kB |

compressed-size-action

tofumatt commented 2 weeks ago

Closing this in favour of #9246, which just exposes these new controls but doesn't migrate to them, as the new API is not desirable 😅