google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 279 forks source link

PAX application not loading correctly on the Ads setup screen. #9237

Closed wpdarren closed 1 week ago

wpdarren commented 2 weeks ago

Bug Description

An issue has occurred where the PAX app is not appearing within the iframe, and is now appearing underneath the WordPress footer. This means that users will not be able to create the ad campaign unless they scroll down the page.

pax

Steps to reproduce

  1. Set up.a site with the PAX pilot plugin (you can use the template in InstaWP)
  2. Go to Settings > Connect More Services and select the Ads module.
  3. Within the setup screen, click on the Create an account CTA
  4. Wait for 20-25 seconds, the app won't load in the iframe but scroll down and you wil see it displayed.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

tofumatt commented 2 weeks ago

ACs are good and IB ✅

mohitwp commented 2 weeks ago

QA Update ✅

https://github.com/user-attachments/assets/1e016432-4cb2-46fb-a2b3-d9d660f9f595