An issue has occurred where the PAX app is not appearing within the iframe, and is now appearing underneath the WordPress footer. This means that users will not be able to create the ad campaign unless they scroll down the page.
Steps to reproduce
Set up.a site with the PAX pilot plugin (you can use the template in InstaWP)
Go to Settings > Connect More Services and select the Ads module.
Within the setup screen, click on the Create an account CTA
Wait for 20-25 seconds, the app won't load in the iframe but scroll down and you wil see it displayed.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
When using the PAX Pilot Plugin, or with the appropriate adsPax feature flag enabled, the PAX application should successfully render within the Ads Module setup container, not outside of it.
Implementation Brief
[ ] Update the versions of both the PAX integrator script and PAX SDK npm package to the latest versions, 1.0.12 at the time of writing:
[ ] Within includes/Modules/Ads.php:
[ ] Locate the pax integrator script URL, https://www.gstatic.com/pax/1.0.9/pax_integrator.js, and update it to be the latest 1.0.12 version: https://www.gstatic.com/pax/1.0.12/pax_integrator.js
[ ] Within package.json:
[ ] Locate the google-pax-sdk dependency entry, update it to match the integrator version, 1.0.12
Test Coverage
No tests needed for this fix.
QA Brief
Using either the PAX Pilot plugin or by enabling the adsPax feature flag:
Validate that PAX application loads within the Ads set up area
Validate that the PAX application and setup process works as intended from account creation to account ID storage within Site Kit
This can be validated by setting up Ads using PAX, and making sure the Ads conversion ID and account ID are stored within the Ads Settings area after completion
Bug Description
An issue has occurred where the PAX app is not appearing within the iframe, and is now appearing underneath the WordPress footer. This means that users will not be able to create the ad campaign unless they scroll down the page.
Steps to reproduce
Connect More Services
and select theAds
module.Create an account
CTADo not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
adsPax
feature flag enabled, the PAX application should successfully render within the Ads Module setup container, not outside of it.Implementation Brief
includes/Modules/Ads.php
:https://www.gstatic.com/pax/1.0.9/pax_integrator.js
, and update it to be the latest 1.0.12 version:https://www.gstatic.com/pax/1.0.12/pax_integrator.js
package.json
:google-pax-sdk
dependency entry, update it to match the integrator version,1.0.12
Test Coverage
QA Brief
adsPax
feature flag:Changelog entry