ACR inline module data - Githubissues

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

https://sitekit.withgoogle.com

Apache License 2.0

1.23k stars 279 forks source link

ACR inline module data #9242

Closed zutigrm closed 2 weeks ago

zutigrm commented 2 weeks ago

Summary

Addresses issue:

9131

Relevant technical choices

PR Author Checklist

[ ] My code is tested and passes existing unit tests.
[ ] My code has an appropriate set of unit tests which all pass.
[ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[ ] My code follows the WordPress coding standards.
[ ] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[ ] Run the code.
[ ] Ensure the acceptance criteria are satisfied.
[ ] Reassess the implementation with the IB.
[ ] Ensure no unrelated changes are included.
[ ] Ensure CI checks pass.
[ ] Check Storybook where applicable.
[ ] Ensure there is a QA Brief.

Merge Reviewer Checklist

[ ] Ensure the PR has the correct target branch.
[ ] Double-check that the PR is okay to be merged.
[ ] Ensure the corresponding issue has a ZenHub release assigned.
[ ] Add a changelog message to the issue.

github-actions[bot] commented 2 weeks ago

Build files for 007ae1b9f739ff805063d62440c01df2f78c3a63 have been deleted.

zutigrm commented 2 weeks ago

Closing this PR in favour of using the settings to retrieve the events list instead of inline module data