Closed benbowler closed 2 weeks ago
Build files for 48197ccb95a960eeb37f9895a71f0342e36abc7f have been deleted.
Size Change: +291 B (+0.02%)
Total Size: 1.79 MB
Filename | Size | Change |
---|---|---|
./dist/assets/js/googlesitekit-main-dashboard-********************.js |
155 kB | +98 B (+0.06%) |
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js |
168 kB | +96 B (+0.06%) |
./dist/assets/js/googlesitekit-widgets-********************.js |
85.3 kB | +97 B (+0.11%) |
Summary
Addresses issue:
8879
Relevant technical choices
The Audience Segmentation components have changed a bit since the IB was written so I audited components that are rendered as part of the AS dashboard widget area and used the
useInViewSelect
for them.These
useSelect
's could not be changed in the current setup: https://github.com/google/site-kit-wp/blob/48197ccb95a960eeb37f9895a71f0342e36abc7f/assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget/index.js#L36-L42This is because the component renders a
WidgetNull
if there are no available audiences which is used by the widget areaisActive
, so if the configured/available audiences aren't queried then the widget will never be shown and therefore will never be in view.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist