Fix publications filtering - Githubissues

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

https://sitekit.withgoogle.com

Apache License 2.0

1.23k stars 279 forks source link

Fix publications filtering #9248

Closed nfmohit closed 1 week ago

nfmohit commented 2 weeks ago

Summary

Addresses issue:

9247

Relevant technical choices

This PR fixes the publications filtering for the RRM GET:publications endpoint.

PR Author Checklist

[x] My code is tested and passes existing unit tests.
[x] My code has an appropriate set of unit tests which all pass.
[ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[ ] My code follows the WordPress coding standards.
[ ] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[x] Run the code.
[x] Ensure the acceptance criteria are satisfied.
[x] Reassess the implementation with the IB.
[x] Ensure no unrelated changes are included.
[ ] Ensure CI checks pass.
[ ] Check Storybook where applicable.
[x] Ensure there is a QA Brief.

Merge Reviewer Checklist

[ ] Ensure the PR has the correct target branch.
[ ] Double-check that the PR is okay to be merged.
[ ] Ensure the corresponding issue has a ZenHub release assigned.
[ ] Add a changelog message to the issue.

github-actions[bot] commented 2 weeks ago

Build files for 9a0cb2762b00f14a73b2802cfcf6ebbc6484d57e have been deleted.

ankitrox commented 1 week ago

Thank you @nfmohit for providing the feedback.

I've addressed both the points and pushed the changes.