Enhancement/8147 full tile error states fixes

techanvil commented 2 weeks ago

Summary

Addresses issue:

8147

This addresses the QA points for the above issue as described here: https://github.com/google/site-kit-wp/issues/8147#issuecomment-2318398607

PR Author Checklist

[ ] My code is tested and passes existing unit tests.
[ ] My code has an appropriate set of unit tests which all pass.
[ ] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[ ] My code follows the WordPress coding standards.
[ ] My code has proper inline documentation.
[ ] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[x] Run the code.
[x] Ensure the acceptance criteria are satisfied.
[x] Reassess the implementation with the IB.
[x] Ensure no unrelated changes are included.
[x] Ensure CI checks pass.
[x] Check Storybook where applicable.
[x] Ensure there is a QA Brief.

Merge Reviewer Checklist

[x] Ensure the PR has the correct target branch.
[x] Double-check that the PR is okay to be merged.
[x] Ensure the corresponding issue has a ZenHub release assigned.
[x] Add a changelog message to the issue.

github-actions[bot] commented 2 weeks ago

Build files for a3d18c7edbf8d0843de9da27cd0d9ba415a16810 have been deleted.

github-actions[bot] commented 2 weeks ago

Size Change: +228 B (+0.01%)

Total Size: 1.8 MB

Filename	Size	Change
`./dist/assets/css/googlesitekit-admin-css-********************.min.css`	57.5 kB	+7 B (+0.01%)
`./dist/assets/js/36-********************.js`	3.12 kB	+1 B (+0.03%)
`./dist/assets/js/googlesitekit-activation-********************.js`	23.8 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js`	71.2 kB	-3 B (0%)
`./dist/assets/js/googlesitekit-adminbar-********************.js`	34.5 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-api-********************.js`	9.97 kB	+2 B (+0.02%)
`./dist/assets/js/googlesitekit-components-gm2-********************.js`	5.97 kB	+1 B (+0.02%)
`./dist/assets/js/googlesitekit-components-gm3-********************.js`	10.1 kB	-1 B (-0.01%)
`./dist/assets/js/googlesitekit-data-********************.js`	2.35 kB	+1 B (+0.04%)
`./dist/assets/js/googlesitekit-datastore-location-********************.js`	2.08 kB	-2 B (-0.1%)
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	26 kB	+2 B (+0.01%)
`./dist/assets/js/googlesitekit-entity-dashboard-********************.js`	83 kB	+5 B (+0.01%)
`./dist/assets/js/googlesitekit-main-dashboard-********************.js`	154 kB	+119 B (+0.08%)
`./dist/assets/js/googlesitekit-modules-ads-********************.js`	32.7 kB	+9 B (+0.03%)
`./dist/assets/js/googlesitekit-modules-adsense-********************.js`	125 kB	-5 B (0%)
`./dist/assets/js/googlesitekit-modules-analytics-4-********************.js`	168 kB	+104 B (+0.06%)
`./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js`	22.4 kB	-1 B (0%)
`./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js`	21.6 kB	-2 B (-0.01%)
`./dist/assets/js/googlesitekit-modules-search-console-********************.js`	58.5 kB	-14 B (-0.02%)
`./dist/assets/js/googlesitekit-notifications-********************.js`	18.5 kB	-1 B (-0.01%)
`./dist/assets/js/googlesitekit-settings-********************.js`	82.9 kB	+6 B (+0.01%)
`./dist/assets/js/googlesitekit-splash-********************.js`	89.4 kB	-100 B (-0.11%)
`./dist/assets/js/googlesitekit-user-input-********************.js`	63 kB	+5 B (+0.01%)
`./dist/assets/js/googlesitekit-vendor-********************.js`	321 kB	+15 B (0%)
`./dist/assets/js/googlesitekit-widgets-********************.js`	85.4 kB	+117 B (+0.14%)
`./dist/assets/js/googlesitekit-wp-dashboard-********************.js`	61.7 kB	-34 B (-0.06%)
`./dist/assets/js/runtime-********************.js`	1.3 kB	-1 B (-0.08%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./dist/assets/css/googlesitekit-adminbar-css-********************.min.css` | 11.8 kB | | `./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css` | 846 B | | `./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css` | 8.2 kB | | `./dist/assets/js/31-********************.js` | 2.76 kB | | `./dist/assets/js/32-********************.js` | 2.25 kB | | `./dist/assets/js/33-********************.js` | 3.64 kB | | `./dist/assets/js/34-********************.js` | 935 B | | `./dist/assets/js/35-********************.js` | 893 B | | `./dist/assets/js/analytics-advanced-tracking-********************.js` | 901 B | | `./dist/assets/js/googlesitekit-consent-mode-********************.js` | 25.6 kB | | `./dist/assets/js/googlesitekit-datastore-forms-********************.js` | 8.95 kB | | `./dist/assets/js/googlesitekit-datastore-site-********************.js` | 20.3 kB | | `./dist/assets/js/googlesitekit-datastore-ui-********************.js` | 9.91 kB | | `./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js` | 646 B | | `./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js` | 624 B | | `./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js` | 630 B | | `./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js` | 712 B | | `./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js` | 675 B | | `./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js` | 634 B | | `./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js` | 657 B | | `./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js` | 633 B | | `./dist/assets/js/googlesitekit-i18n-********************.js` | 3.93 kB | | `./dist/assets/js/googlesitekit-modules-********************.js` | 22.1 kB | | `./dist/assets/js/googlesitekit-modules-tagmanager-********************.js` | 31.9 kB | | `./dist/assets/js/googlesitekit-polyfills-********************.js` | 377 B |

_{compressed-size-action}

techanvil commented 1 week ago

The QA report indicates that the top corners of this error tile should be squared in tabbed breakpoint, which would look like the following:

...

Would this be the expected style? If so, should this be implemented as part of this PR?

Thank you!

Thanks @nfmohit, great spot. This one totally slipped past me. I've pushed an update with a fix, cheers.

google / site-kit-wp