Change font colours to be consistent on RRM setup screens

wpdarren commented 2 weeks ago

Bug Description

When setting up Reader Revenue Manager, we have two font colors on the setup screen when there are no publications. Discussing this with Sigal in Asana, we've decided to make the font colours the same on the setup screens like we did on this step of the workflow. Sigal has updated the figma designs to reflect this.

Discussion in Asana can be found here.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The descriptive text on the "no publications" variant of the RRM setup screen should all be the same color, surfaces/on-surface (#161b18).
When updated, the screen should look like this:

Implementation Brief

In _googlesitekit-rrm-setup-module.scss, remove the $c-surfaces-on-background-variant from the googlesitekit-setup-module__description class: https://github.com/google/site-kit-wp/blob/8629939d3775e26ea5e28a2c11d611005d010486/assets/sass/components/reader-revenue-manager/_googlesitekit-rrm-setup-module.scss#L52-L53

Test Coverage

Update the relevant VRT images.

QA Brief

Reset and setup RRM, confirm the font colors match the image above when reaching the setup screen.

Changelog entry

Update text colour in Reader Revenue Manager publication creation screen.

eugene-manuilov commented 1 week ago

IB ✔️

kelvinballoo commented 4 days ago

QA Update ✅

This is verified good. The descriptive text is now (#161b18) on both lines at the 'No Publications' variant step 1. Also reviewed step 2 to ensure it's still the same.

Moving ticket to Approval.

STEP 1:

STEP 2:

google / site-kit-wp