google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 279 forks source link

Setup CTA Banner doesn't follow the multiple dismissal/settings tooltip pattern #9257

Open wpdarren opened 2 weeks ago

wpdarren commented 2 weeks ago

Bug Description

The Setup CTA banner has a "Maybe later" dismissal CTA. Pressing this dismisses the banner permanently without further information as to where the feature can be set up later. It would be good for the banner to follow the pattern we've introduced whereby: The banner is reshown after a delay (e.g. two weeks), either two or three times, with the dismissal CTA changing to "Don't show again" on the final showing. Upon pressing the dismissal CTA, a tooltip is shown pointing to the Settings menu item advising the user they can set up the feature later in Settings.

Asana ticket can be found here


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test coverage

QA Brief

  1. Enable RRM feature in the tester plugin and make sure to disable RRM module in Site Kit settings.

  2. Go to dashboard, it should display the setup CTA banner.

  3. Click on Maybe later, it will dismiss the banner and will display the tooltip with the text as mentioned in IB.

  4. Install Time Travel extension in chrome and set the date to 15 days or 1 month later. Reload the page.

  5. The banner should be visible again. Dismiss the banner again using Maybe later CTA, it would again display the tooltip.

  6. Change the date in extension further to 1 month and reload the page, the banner should not be visible anymore.

Changelog entry

nfmohit commented 1 week ago

AC ✅

techanvil commented 1 week ago

IB :white_check_mark:

wpdarren commented 3 days ago

QA Update: ✅

Verified:

Screenshots ![image](https://github.com/user-attachments/assets/b82488ac-dec1-455c-a5f4-aa668fc94c45) ![image](https://github.com/user-attachments/assets/5b7a05fb-71ff-44c7-b834-a248c628437c)