search

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 279 forks source link

Improve UX when going back from OAuth and behaviour when redoing process #9261

Open wpdarren opened 2 weeks ago

wpdarren commented 2 weeks ago

Bug Description

Related to setting up the RRM module. When navigating back from the initial OAuth screen, the redo setup CTA is shown. Clicking on this CTA proceeds through the OAuth flow again, but when returning to SK, the RRM setup flow is not continued.

Evan mentioned:

My hunch here is that the redo setup that you're clicking is just a generic link in response to the unsatisfied scopes. It wouldn't be expected to go to the module setup afterwards in this scenario.

Tom responded:

I think you are right about the generic aspect, but it's still something that could be improved in terms of the UX.

Asana ticket can be found here

https://github.com/user-attachments/assets/7426edcf-18ff-4c49-8030-9ca22beb69b5

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

nfmohit commented 2 weeks ago

Just to add: This issue isn't specific to the RRM module, but any other SIte Kit module in general. We can address it as part of the RRM epic, but it can also be a non-epic general enhancement issue. CC: @ivonac4 @techanvil @wpdarren @aaemnnosttv

nfmohit commented 1 week ago

After an internal discussion, we've decided to decouple this from the RRM epic.