google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 279 forks source link

Show 'Display visitor groups in dashboard' toggle even if GA is disconnected #9264

Open kelvinballoo opened 2 weeks ago

kelvinballoo commented 2 weeks ago

Bug Description

This is related to Audience Segmentation

Refer to video further down.

Steps to reproduce

  1. Activate the audienceSegmentation feature flag
  2. Disconnect Google Analytics module
  3. Go to SK settings > Admin settings
  4. *Display visitor groups in dashboard** toggle is not present.

Screenshots

https://github.com/user-attachments/assets/f56fd871-5111-41a2-9ae1-edf3b327539f

Additional Context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

https://github.com/google/site-kit-wp/blob/107a1d0924164ff4e8d5d76c6716f07eea5d0a4c/assets/js/components/settings/SettingsAdmin.js#L149-L153

Test Coverage

QA Brief

  1. Enable the audienceSegmentation feature flag
  2. Set up the Analytics module and enable the Audience Segmentation.
  3. Disconnect Google Analytics module
  4. Go to SK settings > Admin settings
  5. *Display visitor groups in dashboard** toggle should be present.

Changelog entry

nfmohit commented 2 days ago

IB ✅