google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 283 forks source link

Conflict with CartFlows plugin on thank you page. #9276

Open sarangshahane opened 2 weeks ago

sarangshahane commented 2 weeks ago

Bug Description

While using the latest version of this plugin with the CartFlows plugin, there is an Fatal/Critical error is getting generated on the thank you page created by CartFlows. This issue is getting initiated from the WooCommerce action woocommerce_thankyou action hook. In the callback function, there is a check to confirm that the order_key is valid or not.

Before this check, the $order_key added on line number 94 is returning blank and that what is triggering the Fatal/Critical error.

The code: $order->key_is_valid( $order_key ) File location: includes/Core/Conversion_Tracking/Conversion_Event_Providers/WooCommerce.php Line number: 97

Steps to reproduce

  1. Go to 'CartFlows Funnels menu'
  2. Click on 'The eye icon on the thank you page'
  3. Scroll down the page to the end of the page, to see the error.

Screenshots

Additional Context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

jamesozzie commented 1 week ago

Thanks for raising this @sarangshahane. With other users also reporting this I'll perform some checks on this and report back to you here with any findings.