Open sarangshahane opened 2 weeks ago
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Summary
While using the latest version of this plugin with the CartFlows plugin, there is an Fatal/Critical error is getting generated on the thank you page created by CartFlows.
This issue is getting initiated from the WooCommerce action woocommerce_thankyou action hook. In the callback function, there is a check to confirm that the order_key is valid or not.
Before this check, the $order_key added on line number 94 is returning blank and that what is triggering the Fatal/Critical error.
The code:
$order->key_is_valid( $order_key )
File location:includes/Core/Conversion_Tracking/Conversion_Event_Providers/WooCommerce.php
Line number:97
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist