google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 286 forks source link

Fix flaky `AudienceSegmentationSetupCTAWidget` test #9316

Open techanvil opened 2 weeks ago

techanvil commented 2 weeks ago

Feature Description

This test for the AudienceSegmentationSetupCTAWidget component has started failing sporadically in CI:

AudienceSegmentationSetupCTAWidget › CTA actions › should initialise the list of configured audiences when autoSubmit is set to true.

image

This has been seen in develop:

And in a run for a PR (it doesn't appear related to the changes for this PR):


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

In assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupCTAWidget.test.js:

In assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceTilesWidget/index.test.js:

Test Coverage

QA Brief

QA:Eng

Changelog entry

tofumatt commented 2 days ago

This is failing almost all the time now:

Screenshot 2024-09-25 at 22 39 46

We should get this fixed as it's adding time to every review (needing to check to make sure this is the only test that's failing).

If there isn't an immediate solution we should ignore this test, since we already are, but then at least we can see the test run as green and immediately trust it during code review.

benbowler commented 1 day ago

Un-assigning incase anyone can get to this before next week.