google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Release 1.136.0 #9318

Closed tofumatt closed 1 month ago

tofumatt commented 2 months ago

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

QA Brief

Changelog entry

wpdarren commented 1 month ago

QA Update: ⚠️

Update: @techanvil found a regression in this ticket and it has been sent back to Execution for a fix.

I’ve found a regression. Its not user-facing, but we might want to take a look at it. On the main branch (doesn’t occur on 1.135.0) — when I go to Site Kit settings an error occurs in the console.

GET 404 (Not Found) Google Site Kit API Error method:GET datapoint:audience-settings type:core identifier:user error:"No route was found matching the URL and request method."

It appears to be related to Audience Segmentation. No feature flags are enabled. It’s a new website.

image

wpdarren commented 1 month ago

QA Update: ✅

I went through our usual QA checks:

The issue above is with @ankitrox for a PR on 9264.

Notes: I didn't notice any banner notification issues but have asked @mohitwp to go through the testing document for this epic since Phase 1 is finalised. In addition, I haven't included any testing on Reader Revenue Manager, but Mohit and Kelvin are picking this up -- I will spend some time on Monday running through the testing.

tofumatt commented 1 month ago

QA ✅

All looks good to me 👍🏻

hussain-t commented 1 month ago

QA Verified :white_check_mark:

LGTM :+1:

nfmohit commented 1 month ago

Release Tested ✅

mohitwp commented 1 month ago

QA Update ✅

jimmymadon commented 1 month ago

Release Testing ✅

zutigrm commented 1 month ago

QA ✅

LGTM

mohitwp commented 1 month ago

QA Update ⚠️

cc @nfmohit @wpdarren

mohitwp commented 1 month ago

QA Update ✅