Closed tofumatt closed 1 month ago
Update: @techanvil found a regression in this ticket and it has been sent back to Execution for a fix.
I’ve found a regression. Its not user-facing, but we might want to take a look at it. On the main branch (doesn’t occur on 1.135.0) — when I go to Site Kit settings an error occurs in the console.
GET 404 (Not Found) Google Site Kit API Error method:GET datapoint:audience-settings type:core identifier:user error:"No route was found matching the URL and request method."
It appears to be related to Audience Segmentation. No feature flags are enabled. It’s a new website.
I went through our usual QA checks:
The issue above is with @ankitrox for a PR on 9264.
Notes: I didn't notice any banner notification issues but have asked @mohitwp to go through the testing document for this epic since Phase 1 is finalised. In addition, I haven't included any testing on Reader Revenue Manager, but Mohit and Kelvin are picking this up -- I will spend some time on Monday running through the testing.
All looks good to me 👍🏻
LGTM :+1:
LGTM
cc @nfmohit @wpdarren
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
QA Brief
Changelog entry