Go over the assets/js/googlesitekit/notifications/register-defaults.js and check if there are resolvers, or selectors that are using different resolvers (like in the case of hasZeroData) in checkRequirements that might be missed, and are retrieved using select instead of resolveSelect. One such example is isModuleConnected which is currently not resolved. There might be more
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
All the data used in checkRequirements property of currently registered notifications should be properly resolved where needed - specifically when retrieving the data from resolvers.
One such example is isModuleConnected which is currently not resolved
Data from isModuleConnected resolver should be retrieved with resolveSelect and awaited
There are few selectors, which rely on data from different resolver, which can't guarantee having data available at the point when notifications API is invoked, although there is good chance this data is already resolved and available due to requests for this mandatory data is done very early.
isAuthenticated and getUnsatisfiedScopes selectors are both using getAuthentication resolver, which fetches the needed data.
canViewSharedModule selector, is relying on having data from getModule resolver.
Invoke these dependency resolvers and await them before the selectors are called, to ensure data is resolved properly
Check if there is any other resolver that might be missed, in case new notifications are added after this IB has been written.
Feature Description
Go over the
assets/js/googlesitekit/notifications/register-defaults.js
and check if there are resolvers, or selectors that are using different resolvers (like in the case ofhasZeroData
) incheckRequirements
that might be missed, and are retrieved usingselect
instead ofresolveSelect
. One such example isisModuleConnected
which is currently not resolved. There might be moreDo not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
checkRequirements
property of currently registered notifications should be properly resolved where needed - specifically when retrieving the data from resolvers.isModuleConnected
which is currently not resolvedImplementation Brief
assets/js/googlesitekit/notifications/register-defaults.js
isModuleConnected
resolver should be retrieved withresolveSelect
and awaitedisAuthenticated
andgetUnsatisfiedScopes
selectors are both usinggetAuthentication
resolver, which fetches the needed data.canViewSharedModule
selector, is relying on having data fromgetModule
resolver.Test Coverage
QA Brief
Changelog entry