Closed zutigrm closed 1 month ago
Build files for 498839bfc40b775f3b56617a981839e76df5a59f have been deleted.
Size Change: +7 B (0%)
Total Size: 1.8 MB
Filename | Size | Change |
---|---|---|
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js |
170 kB | +7 B (0%) |
Summary
Addresses issue:
9154
Relevant technical choices
*. Issue covers only the filtering of
not set
dimension value, the other point in the QA observation - removing the widget when feature flag is disabled, is not included as part of this PR, as metrics will remain saved in the DB, and will need to think about some mechanism of solving that issue if it is necessary (will consult with Evan first if this kind of effort is needed)One Note: Although this issue filters out the
not set
, this is not removed from the stories, as this is part of the default cities array in the mock data, and there is already an issue that focuses on filtering outnot set
in all key metrics that can have it as value in dimension, sonot set
will be removed from mocked data there. Removing it here would also affect stories of other widgets.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist