google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Temporarily Hidden badge UX issues #9421

Closed kelvinballoo closed 1 month ago

kelvinballoo commented 1 month ago

Bug Description

2 Issues to highlight:

Steps to reproduce

  1. Enable audience segmentation feature and enable the visitor groups. Add the non Site Kit created audience to audience tile like "All visitors" and also a SK created audience "New Visitors"

  2. In the tester plugin, set Analytics > Force Analytics report data to Zero. Also, set Analytics Partial Data > Force Analytics audience partial data state to last-28-days. Save changes.

  3. Go to Site Kit dashboard and to audience tile section. You will see the tile in collecting data status with the link to hide the tile temporarily ( "Temporarily hide" ).

  4. Click on the "Temporarily hide" link for "All Visitors", that will hide the tile.

  5. Open the audience selection panel. There should be a "Temporarily Hidden" badge with a tooltip.

Click on the 'i' icon for the "Temporarily Hidden" badge and you will notice it will check on and off the checkbox. Also, when tapping on mobile, the UX is weird. The tooltip only appears as long as we press the tooltip. If we lift the finger, it's gone.

Screenshots

Additional Context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Note, this issue only needs to tackle the GM2 version of Checkbox - we can port the changes across to the GM3 version to keep them aligned in a separate issue, https://github.com/google/site-kit-wp/issues/9423.

Test Coverage

QA Brief

Changelog entry

nfmohit commented 1 month ago

IB ✅

mohitwp commented 1 month ago

QA Update ✅

https://github.com/user-attachments/assets/b3129472-14eb-422b-91bc-0baeebba3b72