Closed 10upsimon closed 2 weeks ago
AC ✅
@10upsimon Perhaps it will be more straightforward to change it directly in the backend when feature flag is enabled, in Google\Site_Kit\Modules\Ads::setup_info
?
@10upsimon Perhaps it will be more straightforward to change it directly in the backend when feature flag is enabled, in
Google\Site_Kit\Modules\Ads::setup_info
?
@zutigrm ya, good shout, let me update.
Thanks @10upsimon IB ✅
With the adsPAX feature flag disabled the copy is: "Track conversions for your existing Google Ads campaigns"
With the adsPAX feature flag enabled the copy is: "Grow sales, leads or awareness for your business by advertising with Google Ads"
Feature Description
For users enrolled in the Beta phase of the Ads PAX integration (those using the mini plugin), the Ads module setup text appearing on the "Connect More Services" screen is required to be updated to be more reflective of a scenario where users do not have an existing Ads account.
The new setup text should read as follows:
Grow sales, leads or awareness for your business by advertising with Google Ads
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Google Site Kit > Settings
should be amended to read as follows: "Grow sales, leads or awareness for your business by advertising with Google Ads"adsPAX
feature flag is detected.Implementation Brief
includes/Modules/Ads.php
setup_info()
method:description
array key based on whether the result ofFeature_Flags::enabled( 'adsPax' )
istrue
or not.Test Coverage
QA Brief
Changelog entry