Connect Analytics CTA does not appear when Analytics is disconnected, and Settings section disappears

[techanvil]

Bug Description

Steps to reproduce

1. Setup the Audience Segmentation feature.
2. Disconnect Analytics and navigate to the dashboard.
3. The Audiences Widget Area will not be shown at all, while it should display the Connect Analytics CTA.
4. Navigate to the Settings > Admin Settings screen.
5. The "Visitor groups" section will not be visible, while it's expected to be showing the "Display visitor groups in dashboard" toggle.

Additional Context

• PHP Version: any
• OS: any
• Browser: any
• Plugin Version: 1.137.0 pre release, in development
• Device: any

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When the Audience Segmentation feature has been set up, and Analytics is subsequently disconnected:
  • The Connect Analytics CTA should be displayed in the Audiences Widget Area.
  • The "Visitor groups" section should be displayed on the Settings screen with the "Display visitor groups in dashboard" toggle present.
• When Analytics is reconnected:
  • If it's reconnected with the same property, the previous state of the Audience Segmentation feature should be restored.
  • If it's reconnected with a different property, the feature should be reset as per https://github.com/google/site-kit-wp/issues/8180.

Implementation Brief

• [ ] Add a new Analytics setting, previousPropertyID, to track the previously connected Analytics property ID.
• [ ] Ensure the Analytics settings availableAudiences, audienceSegmentationSetupCompletedBy, availableAudiencesLastSyncedAt, and previousPropertyID are retained when Analytics is deactivated. Additionally, don't call Reset_Audiences::reset_audience_data() when Analytics is deactivated.
• [ ] Ensure the above settings are only reset when a different property is connected, comparing propertyID to previousPropertyID in the pre_update_option_googlesitekit_analytics-4_settings hook.
• Finish off PR: https://github.com/google/site-kit-wp/pull/9450

Test Coverage

• Update/fix test coverage to accommodate the above changes.

QA Brief

Changelog entry

[aaemnnosttv]

@techanvil I must have missed this during UX review because I feel that the expectation as a wholly Analytics-powered feature should be that it no longer has a presence on the dashboard when disconnected (aside from perhaps a generic CTA to connect GA as when originally setting up) just like any other. It seems this has been conceptually modeled after Key Metrics which was the first instance where such a "GA disconnected" informational banner was introduced because nearly all metrics come from GA but not all which made it a dependency. It's also possible because KM has its own settings which are independent from all modules. Given audiences are specific to GA, this doesn't seem like something we should do, and instead the UX should be updated to reflect this.

This will require some additional conversations I'm sure, but even if this was previously discussed I'd like to revisit it before we move forward here. This may affect other issues in motion or hopefully not any which have been already been done, but if so please let me know.

[techanvil]

Thanks @aaemnnosttv, that makes sense to me. We have already implemented the Connect CTA Banner, but we can simply back that code out if we decide not to include it. It's not something we need to do for the bug bash as the code path for showing it is simply no longer reached and the feature is effectively reset when Analytics is disconnected.

I've marked this as a P2 and moved it to the Backlog so we can continue the conversation post bug bash and make the call on how to proceed. Cc @ivonac4