Open wpdarren opened 1 week ago
Thank you for drafting the IB, @techanvil !
- In the
DashboardMainApp
component, retrieveconfiguredAudiences
via thegetConfigurableAudiences()
selector. Extend the condition for renderingAudienceSelectionPanel
to include a check forconfiguredAudiences
being truthy.
Just to confirm, did you mean the core/user
getConfiguredAudiences
selector instead?
Thanks for spotting that, @nfmohit! It was indeed a typo, which I've fixed. Back to you for another pass :)
IB ✅
Bug Description
Issue discovered during bug bash. Asana task here
The Audiences Selection Panel component is rendered into the DOM before the feature has been set up.
I spotted this when I noticed that a request to sync-audiences is made when landing on the dashboard prior to the Audience Segmentation Setup CTA Banner being displayed and actioned.
We should not be rendering the selection panel at all prior to the feature being set up.
Screenshots
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
DashboardMainApp
component, retrieveconfiguredAudiences
via thegetConfiguredAudiences()
selector. Extend the condition for renderingAudienceSelectionPanel
to include a check forconfiguredAudiences
being truthy.https://github.com/google/site-kit-wp/blob/3ff3c69cce3f17ec310f57e0a3cfe8aebe2e2759/assets/js/components/DashboardMainApp.js#L297
Test Coverage
QA Brief
Changelog entry