The Loading scenario is covered in a single MetricTileNumeric component.
The Zero Data scenario is covered once in each of the three MetricTile___ components as they all "differ" slightly.
The Gathering Data, Error, Insufficient Permissions and Custom Dimension error scenarios are all covered once in the first KMW tile component that appears in the list of stories.
As per my conversation with @tofumatt, all other scenarios have been deleted. A follow up issue, #9479 has been created to convert logic within all of these scenarios into Jest tests if necessary. We need to define properly which tests are needed and how to create reusable utility methods that can be used to set up the above states for each tile.
All old VRT reference images not being tested anymore have been pruned.
The delay property of 250ms has not been removed for now as this property over rides the default 1 sec delay set for all tests. This could cause the tests to take longer to run. However, testing this is time consuming and can be done in another issue.
PR Author Checklist
[x] My code is tested and passes existing unit tests.
[ ] My code has an appropriate set of unit tests which all pass.
[x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[x] My code follows the WordPress coding standards.
[x] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
Summary
Addresses issue:
8418
Relevant technical choices
MetricTileNumeric
component.MetricTile___
components as they all "differ" slightly.As per my conversation with @tofumatt, all other scenarios have been deleted. A follow up issue, #9479 has been created to convert logic within all of these scenarios into Jest tests if necessary. We need to define properly which tests are needed and how to create reusable utility methods that can be used to set up the above states for each tile.
All old VRT reference images not being tested anymore have been pruned.
The
delay
property of 250ms has not been removed for now as this property over rides the default 1 sec delay set for all tests. This could cause the tests to take longer to run. However, testing this is time consuming and can be done in another issue.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist