Split the "Sell products or services" answer in the User Input app

[benbowler]

Feature Description

As part of the updates to the User Input app, the existing "Sell products or services" question should be split into to separate questions, this requires some additional changes to logic to handle the behaviour with the legacy answer, as well as a banner for users who have previously selected the combined option. As part of this issue, only answer split should be added, banner will be implemented as separate issue

The proposed solution was discussed in a thread with @aaemnnosttv and @sigal-teller (message @benbowler for details), the summary of which is the following. Existing users who have selected the combined option should not be automatically migrated, these users should see a new banner in the Admin Settings screen when editing their metrics encouraging them to update the answer. The app metrics selection should continue working with the legacy combine answer selected.

This additional scope was first identified in #9374.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Existing purpose answer "Sell products or services" is split into two new answers:

  • Sell products
  • Provide services

• New descriptions should be included under each answer, and answers should be added in order shown in Figma here and here

• The legacy answer "Sell products or services" should still have an effect with the existing users that previously saved it, but it should be hidden from the answers list in the user input - both for new setup, and in the list when answer is edited in the key metrics section of the admin settings.

  • For existing users, when editing the answer, Sell products which should be the first answer in the list, should be preselected by default

• Tailored metrics should be adapted for each new answer, following the KMW grouping from this table:

• Check Splitting “Sell products or services” site purpose answer section of the design doc

Implementation Brief

• [x] Within the user-input data store constants file at assets/js/components/user-input/util/constants.js
  • [x] Define the new answers for Sell products and Provide services within the existing getUserInputAnswers() function
  • [x] Define the new answer descriptions for Sell products and Provide services within the existing getUserInputAnswersDescription() function
• [x] Within the key-metrics user datastore partial at assets/js/googlesitekit/datastore/user/key-metrics.js
  • [x] Update the getAnswerBasedMetrics selector, mapping the correct metrics to the respective Sell products and Provide services answer types
  • [x] Leave the existing mapping for sell_products_or_service intact
• [x] Within the UserInputSelectOptions component at assets/js/components/user-input/UserInputSelectOptions.js
  • [x] If the slug attribute is equal to USER_INPUT_QUESTIONS_PURPOSE, add/update the following logic:
    • [x] If the currently chosen value is that of the legacy sell_products_or_service type/value, ensure that the Sell products option is pre-selected

Test Coverage

• Update the tests at assets/js/googlesitekit/datastore/user/key-metrics.test.js and ensure that the correct metrics are returned for the 2x newly added purpose types.

QA Brief

• Switch to a release or branch prior to this change
• Set up Site Kit with KMW, using the tailored option, choosing "Sell products or services" as a site purpose
• Switch to the branch containing this body of work
• Navigate to Site Kit > Settings > Admin
• Under Key Metrics header, validate that the correct purpose shows: "Sell products or services"
• Click on the edit CTA next to purpose
• Validate that "Sell products or services" is no longer an option in the list and that "Sell products" is now selected
• Confirm that the "Apply change" CTA button is present at the bottom of the settings edit group
• Cancel (do not apply) and confirm the label returns to "Sell products or services"
• Edit the purpose again, but this time apply the changes (Note this specific scenario will not trigger the modal, as both answers have the same metrics)
• Confirm that "Sell products" is now the selected purpose, and persists as such on page reload
• See attached gif below for an example

Changelog entry

• Split the "Sell products or services" answer in the User Input app.

[zutigrm]

Taking this back to AC with me, pending the new tailored metrics that should be added for each new answer. Current thread for this

[10upsimon]

AC looks good to me here ✅ I will move to IB and pick up myself.

[zutigrm]

IB ✅

[jimmymadon]

@10upsimon I noticed the PR here created 5 metric tiles for the provide_services option. If ACR is not active, then the max number of tiles should be 4. Could we please bring this back down to 4 metrics?

https://github.com/google/site-kit-wp/blob/8913261d60a8593fe7bff01fac23086f7b5c6e71/assets/js/googlesitekit/datastore/user/key-metrics.js#L338-L344

[mohitwp]

QA Update :X

• Tested on dev environment.
• Tested when 'connversionReporting'feature flag is not enabled.
• Tested when 'connversionReporting'feature flag is enabled.

@10upsimon

Issue 1) 'connversionReporting'feature flag is not enabled. When I select purpose 'Provide services' then 5 metric tiles are showing. It should display 4 metric tiles.


Issue-2 ) When I select purpose 'Sell Products" and if "WooCommerce" plugin is active then 4 metric tiles are showing.

• Most popular products by pageviews
• Top traffic source
• Most engaged traffic source
• Top performing keywords

As per AC metric list "Most engaged traffic source" should be listed when purpose is "Provide Services". When 'connversionReporting'feature flag is enabled then metrics are showing correctly as per table mentioned under AC.

 'conversionReporting' feature flag is enabled "Sell Products" 

Q -3) The Figma design for the "Answers Edit Screen" also includes a description, but this has not been implemented yet. I also tested this with ACR enabled. Do we have a separate ticket to implement this?