Enhancement/9377 Enable Dashboard Sharing for ACR tiles

jimmymadon commented 3 weeks ago

Summary

Addresses issue:

9377

Relevant technical choices

PR Author Checklist

[x] My code is tested and passes existing unit tests.
[ ] My code has an appropriate set of unit tests which all pass.
[x] My code is backward-compatible with WordPress 5.2 and PHP 7.4.
[x] My code follows the WordPress coding standards.
[x] My code has proper inline documentation.
[x] I have added a QA Brief on the issue linked above.
[x] I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

[ ] Run the code.
[ ] Ensure the acceptance criteria are satisfied.
[ ] Reassess the implementation with the IB.
[ ] Ensure no unrelated changes are included.
[ ] Ensure CI checks pass.
[ ] Check Storybook where applicable.
[ ] Ensure there is a QA Brief.
[ ] Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

[ ] Ensure the PR has the correct target branch.
[ ] Double-check that the PR is okay to be merged.
[ ] Ensure the corresponding issue has a ZenHub release assigned.
[ ] Add a changelog message to the issue.

github-actions[bot] commented 2 weeks ago

Build files for 52da7fa50e6792f1c376df23a9ac4866daa64949 have been deleted.

jimmymadon commented 2 weeks ago

Note for CR / MR: VRT and E2E test failures here are unrelated to this PR and are known issues.

github-actions[bot] commented 2 weeks ago

Size Change: +29 B (0%)

Total Size: 1.83 MB

Filename	Size	Change
`./dist/assets/js/googlesitekit-datastore-user-********************.js`	26.8 kB	+29 B (+0.11%)

ℹ️ View Unchanged

| Filename | Size | | :--- | :---: | | `./dist/assets/css/googlesitekit-admin-css-********************.min.css` | 58.9 kB | | `./dist/assets/css/googlesitekit-adminbar-css-********************.min.css` | 11.8 kB | | `./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css` | 846 B | | `./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css` | 8.2 kB | | `./dist/assets/js/32-********************.js` | 2.76 kB | | `./dist/assets/js/33-********************.js` | 2.25 kB | | `./dist/assets/js/34-********************.js` | 3.64 kB | | `./dist/assets/js/35-********************.js` | 935 B | | `./dist/assets/js/36-********************.js` | 893 B | | `./dist/assets/js/37-********************.js` | 1.61 kB | | `./dist/assets/js/38-********************.js` | 1.57 kB | | `./dist/assets/js/39-********************.js` | 1.61 kB | | `./dist/assets/js/40-********************.js` | 1.59 kB | | `./dist/assets/js/41-********************.js` | 1.64 kB | | `./dist/assets/js/42-********************.js` | 3.12 kB | | `./dist/assets/js/analytics-advanced-tracking-********************.js` | 901 B | | `./dist/assets/js/googlesitekit-activation-********************.js` | 23.9 kB | | `./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js` | 54.7 kB | | `./dist/assets/js/googlesitekit-adminbar-********************.js` | 34.5 kB | | `./dist/assets/js/googlesitekit-api-********************.js` | 10.1 kB | | `./dist/assets/js/googlesitekit-components-gm2-********************.js` | 6.05 kB | | `./dist/assets/js/googlesitekit-components-gm3-********************.js` | 10.1 kB | | `./dist/assets/js/googlesitekit-consent-mode-********************.js` | 25.6 kB | | `./dist/assets/js/googlesitekit-data-********************.js` | 2.37 kB | | `./dist/assets/js/googlesitekit-datastore-forms-********************.js` | 8.94 kB | | `./dist/assets/js/googlesitekit-datastore-location-********************.js` | 2.08 kB | | `./dist/assets/js/googlesitekit-datastore-site-********************.js` | 20.5 kB | | `./dist/assets/js/googlesitekit-datastore-ui-********************.js` | 10 kB | | `./dist/assets/js/googlesitekit-entity-dashboard-********************.js` | 81.3 kB | | `./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js` | 646 B | | `./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js` | 624 B | | `./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js` | 630 B | | `./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js` | 712 B | | `./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js` | 675 B | | `./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js` | 634 B | | `./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js` | 657 B | | `./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js` | 633 B | | `./dist/assets/js/googlesitekit-i18n-********************.js` | 3.93 kB | | `./dist/assets/js/googlesitekit-main-dashboard-********************.js` | 156 kB | | `./dist/assets/js/googlesitekit-modules-ads-********************.js` | 33.4 kB | | `./dist/assets/js/googlesitekit-modules-adsense-********************.js` | 111 kB | | `./dist/assets/js/googlesitekit-modules-analytics-4-********************.js` | 178 kB | | `./dist/assets/js/googlesitekit-modules-********************.js` | 22.2 kB | | `./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js` | 22.6 kB | | `./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js` | 40.6 kB | | `./dist/assets/js/googlesitekit-modules-search-console-********************.js` | 59.5 kB | | `./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js` | 18.1 kB | | `./dist/assets/js/googlesitekit-modules-tagmanager-********************.js` | 32.1 kB | | `./dist/assets/js/googlesitekit-notifications-********************.js` | 22.7 kB | | `./dist/assets/js/googlesitekit-polyfills-********************.js` | 377 B | | `./dist/assets/js/googlesitekit-settings-********************.js` | 118 kB | | `./dist/assets/js/googlesitekit-splash-********************.js` | 68.8 kB | | `./dist/assets/js/googlesitekit-user-input-********************.js` | 43.6 kB | | `./dist/assets/js/googlesitekit-vendor-********************.js` | 321 kB | | `./dist/assets/js/googlesitekit-widgets-********************.js` | 89.9 kB | | `./dist/assets/js/googlesitekit-wp-dashboard-********************.js` | 62.5 kB | | `./dist/assets/js/runtime-********************.js` | 1.4 kB |

_{compressed-size-action}

tofumatt commented 1 week ago

This will all be handled in #9548 so approving this one 👍🏻

google / site-kit-wp