Closed benbowler closed 3 weeks ago
Note for @kelvinballoo during QA, the list of metrics for each survey setting should not match the image in the ticket:
Note: the KM_ANALYTICS_TOP_DEVICE_DRIVING_PURCHASES metrics is not yet implemented so when sell_products_or_service is selected there will only be 7 widgets shown.
Also @zutigrm has confirmed in Slack that the order of the widgets shown in the Key Metrics section is not important as long as they are all there.
Build files for 9dd60221704d9e4370f5afbb5437960905ae98dc have been deleted.
Size Change: +222 B (+0.01%)
Total Size: 1.82 MB
Filename | Size | Change |
---|---|---|
./dist/assets/js/googlesitekit-activation-********************.js |
23.9 kB | +2 B (+0.01%) |
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js |
54.7 kB | +90 B (+0.16%) |
./dist/assets/js/googlesitekit-adminbar-********************.js |
34.5 kB | -2 B (-0.01%) |
./dist/assets/js/googlesitekit-api-********************.js |
10.1 kB | -1 B (-0.01%) |
./dist/assets/js/googlesitekit-datastore-forms-********************.js |
8.95 kB | +1 B (+0.01%) |
./dist/assets/js/googlesitekit-datastore-site-********************.js |
20.5 kB | +2 B (+0.01%) |
./dist/assets/js/googlesitekit-datastore-ui-********************.js |
10.1 kB | +1 B (+0.01%) |
./dist/assets/js/googlesitekit-datastore-user-********************.js |
26.7 kB | -15 B (-0.06%) |
./dist/assets/js/googlesitekit-entity-dashboard-********************.js |
81.3 kB | +56 B (+0.07%) |
./dist/assets/js/googlesitekit-main-dashboard-********************.js |
156 kB | +3 B (0%) |
./dist/assets/js/googlesitekit-modules-********************.js |
22.3 kB | +3 B (+0.01%) |
./dist/assets/js/googlesitekit-modules-ads-********************.js |
33.3 kB | +38 B (+0.11%) |
./dist/assets/js/googlesitekit-modules-adsense-********************.js |
111 kB | +6 B (+0.01%) |
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js |
177 kB | +10 B (+0.01%) |
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js |
22.7 kB | +1 B (0%) |
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js |
40.6 kB | +25 B (+0.06%) |
./dist/assets/js/googlesitekit-modules-search-console-********************.js |
59.5 kB | +25 B (+0.04%) |
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js |
10.9 kB | -1 B (-0.01%) |
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js |
32.2 kB | -26 B (-0.08%) |
./dist/assets/js/googlesitekit-settings-********************.js |
118 kB | +5 B (0%) |
./dist/assets/js/googlesitekit-splash-********************.js |
68.8 kB | +60 B (+0.09%) |
./dist/assets/js/googlesitekit-user-input-********************.js |
43.6 kB | -124 B (-0.28%) |
./dist/assets/js/googlesitekit-widgets-********************.js |
90 kB | +49 B (+0.05%) |
./dist/assets/js/googlesitekit-wp-dashboard-********************.js |
62.4 kB | +14 B (+0.02%) |
Test failures seem unrelated…
Test failures seem unrelated…
Hmm, actually the assets/js/googlesitekit/datastore/user/key-metrics.test.js
failures do appear to be caused by the commit in this PR. I've sent the issue back to @benbowler for a followup fix.
Thanks @techanvil, I've fixed these tests and we should get this through quickly to allow other developers to see more clearly if tests are passing.
Thanks @benbowler, and agreed, I'll review that now to move it along.
Summary
Addresses issue:
9437
Relevant technical choices
I updated the displayed metrics based on the image in the ticket rather than the list in the design doc.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist